parameter passed to SecurityGroupRuleExists doesn't match expect

[Wei Wang]

When we use db.securitygroups_db.SecurityGroupDbMixin._check_for_duplicate_rules() to check whether a
security group rule exists, exception SecurityGroupRuleExists will be raised if true, but the id we passed is
security rule id, which SecurityGroupRuleExists expect is a security group id.

I think this is the exception's fault, if this is confirmed, I'll fix the exception ASAP.

    def _check_for_duplicate_rules(self, context, security_group_rules):
            ...
            filters = self._make_security_group_rule_filter_dict(i)
            db_rules = self.get_security_group_rules(context, filters)
            ...

            for db_rule in db_rules:
                # need to remove id from db_rule for matching
                id = db_rule.pop('id')
                if (i['security_group_rule'] == db_rule):
                    raise ext_sg.SecurityGroupRuleExists(id=id)

    class SecurityGroupRuleExists(qexception.InUse):
        message = _("Security group rule already exists. Group id is %(id)s.")

[Wei Wang (damon-devops)]

Why I think this is a exception's fault:

1. the duplicate item is rule, not group
2. even rules is same, if they don't belong to a same group, it is fine, so hint a group id means little.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113551

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113551
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8fd377514026347e712bfa74faa351b580408e4e
Submitter: Jenkins
Branch: master

commit 8fd377514026347e712bfa74faa351b580408e4e
Author: Wei Wang <email address hidden>
Date: Tue Aug 12 22:59:18 2014 +0800

    SecurityGroupRuleExists should point out rule id inseand of group id

    When we get a SecurityGroupRuleExists, we want to get the rule id
    instaed of group id, and this is what the fucntion
    _check_for_duplicate_rules() does.

    Change-Id: I9b526d9829582cb26bfda98bcaf1704fe8681cbe
    Closes-bug: #1354343