Some I18N strings are not translator friendly

Bug #1354125 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

horizon/templates/horizon/common/_usage_summary.html:
blocktrans contains non-simple HTML tags and the range of blocktrans seems natural.

   <form action="?" method="get" id="date_form" class="form-inline">
     <h3>{% trans "Select a period of time to query its usage" %}: </h3>
     <div class="datepicker form-group">
     {% blocktrans with start=form.start end=form.end %}
     <label>From:</label> {{ start }}
     </div>
     <div class="datepicker form-group">
       <label>To:</label>{{ end }}{% endblocktrans %}
     </div>

openstack_dashboard/dashboards/admin/images/templates/images/properties/_edit.html:
The sensence and the value are concatenated in the code and translators cannot control the word order.

  <p>{% trans 'Update the custom property value for' %} &quot;{{ key }}&quot;</p>

Tags: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112647

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/112647
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1c84b18d192766a26b4375d4f7a2cf152d991e74
Submitter: Jenkins
Branch: master

commit 1c84b18d192766a26b4375d4f7a2cf152d991e74
Author: Akihiro Motoki <email address hidden>
Date: Fri Aug 8 03:18:25 2014 +0900

    Make some new strings translator friendly

    _usage_summary.html:
    blocktrans contains non-simple HTML tags and the range
    of blocktrans seems natural. This commit split blocktrans
    into the start and end part of the period.

    templates/images/properties/_edit.html:
    The sensence and the value are concatenated in the code
    and translators cannot control the word order.

    Change-Id: I3021d67dcb20968b785a8a98ed639a128e3412f2
    Closes-Bug: #1354125

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.