angular/horizon.js puts vars in global namespace

[Randy Bertram]

In horizon/static/horizon/js/angular/horizon.js, there is no encapsulation. The variables horizon_dependencies and dependencies are only used locally, but are placed in the global namespace. Encapsulating the file would also allow for strict mode.

(The variable horizonApp has to be placed in the global namespace, since it is referenced elsewhere. It should perhaps be eliminated in favor of just referencing angular.module('hz'), but that is a different issue.)

[Julie Pichon (jpichon)]

Patch at https://review.openstack.org/#/c/112654/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112654
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=21d878531a97a6e1a9c3e09bc2a73bfe89014cc9
Submitter: Jenkins
Branch: master

commit 21d878531a97a6e1a9c3e09bc2a73bfe89014cc9
Author: Randy Bertram <email address hidden>
Date: Thu Aug 7 14:52:08 2014 -0400

    With angular hz module, use strict & avoid globals

    Change-Id: I28a1a71f362045769083b90e15a6ad9ee19d090a
    Closes-Bug: 1354120