logging audit change broke logging (found one)

Bug #1354107 reported by Amrith Kumar
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
High
Amrith Kumar

Bug Description

My recent change

https://github.com/openstack/trove/commit/b668e85cb6d8d147fde22e2b43897ea2cc024db0

introduced a problem. Not sure why I didn't catch it sooner but just hit this problem.

https://github.com/openstack/trove/blame/master/trove/guestagent/volume.py#L93-L94

 LOG.debug("Formatting %s. Executing: %s.",
  (self.device_path, cmd))

Yeah, no. That's wrong.

Amrith Kumar (amrith)
Changed in trove:
assignee: nobody → Amrith (amrith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112634

Changed in trove:
status: New → In Progress
Denis M. (dmakogon)
Changed in trove:
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/112634
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=ceecea991bd4e5209fe4a9fe82b543648634551d
Submitter: Jenkins
Branch: master

commit ceecea991bd4e5209fe4a9fe82b543648634551d
Author: Amrith Kumar <email address hidden>
Date: Thu Aug 7 13:30:10 2014 -0400

    recent audit log change broke this LOG.debug message

    My recent change to this file as part of the audit logging changes
    (b668e85c) introduced this error.

    Change-Id: If540d94432835f7f28817b00a39c5c704cb71813
    Closes-Bug: #1354107

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.