Mir

Mir test code (and possibly production code) leaks fds

Bug #1353961 reported by Alexandros Frantzis
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Mir development team
Mir 0.7.0
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Steps to reproduce: valgrind --tool=none --track-fds=yes mir_(unit|integration|acceptance)_tests

Expected result: No fds are leaked
Actual result: A lot of fds are leaked

As with memory errors it's important to reach a state where we don't leak any fds in our tests. This will helps us catch fd leak regressions in production code. When we reach the zero leak state we can enable --track-fds=yes in CI.

See, for example, https://bugs.launchpad.net/mir/+bug/1353461 which was caused by fd leaks both in test code and _production code_, and was lost in the fd leak noise we currently produce.

Tags: testsfail

Related branches

lp:~afrantzis/mir/fix-1353461-prompt-session-fd-leaks
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Alan Griffiths: Approve
Diff: 73 lines (+12/-7)
2 files modified
src/server/frontend/session_mediator.cpp (+2/-0)
tests/acceptance-tests/test_prompt_session_client_api.cpp (+10/-7)
Daniel van Vugt (vanvugt)
tags: added: testsfail
Changed in mir:
status: New → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.7.0
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.7.0 → 0.8.0
Revision history for this message
kevin gunn (kgunn72) wrote :

this was fixed in mir0.7 according to changelog

Changed in mir:
status: Triaged → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.8.0 → 0.7.0
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
Changed in mir (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Revision history for this message
Kevin DuBois (kdub) wrote :

The fix fixed one issue... it did not fix all the fds leaked in the tests.

Changed in mir:
status: Fix Released → Confirmed
assignee: Alexandros Frantzis (afrantzis) → Mir development team (mir-team)
Revision history for this message
Kevin DuBois (kdub) wrote :

I moved back to confirmed, and will link in specific issues to this bug.

After we get --track-fds = yes to produce clean output, we'll turn it on that flag in our valgrind runs.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

LP and our tools will get confused if we re-fix an already released bug... So despite reopening sounding correct, please log a new one instead.

Changed in mir:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.