ResourceFailure error on adopting a stack having a resource group

[Unmesh Gurjar]

Branch: master

Steps to reproduce:
1. Create a stack with attached template.
2. Abandon the stack.
3. Using the attached template and adopt file returned in step #2, execute stack-adopt.

Expected result:
Stack should get adopted successfully.

Actual result:
Stack adopt fails with the following traceback:

2014-08-07 14:53:56.481 DEBUG heat.engine.scheduler [-] Task stack_task from Stack "rd_adopt" [48860293-8e61-42d0-a333-ff4c2a252a77] starting from (pid=9036) start /opt/stack_master/heat/heat/engine/scheduler.py:158
2014-08-07 14:53:56.482 DEBUG heat.engine.scheduler [-] Task stack_task from Stack "rd_adopt" [48860293-8e61-42d0-a333-ff4c2a252a77] running from (pid=9036) step /opt/stack_master/heat/heat/engine/scheduler.py:191
2014-08-07 14:53:56.495 INFO heat.engine.stack [-] Stack ADOPT IN_PROGRESS (rd_adopt): Stack ADOPT started
2014-08-07 14:53:56.497 DEBUG heat.engine.scheduler [-] Task resource_action starting from (pid=9036) start /opt/stack_master/heat/heat/engine/scheduler.py:158
2014-08-07 14:53:56.499 DEBUG heat.engine.scheduler [-] Task resource_action running from (pid=9036) step /opt/stack_master/heat/heat/engine/scheduler.py:191
2014-08-07 14:53:56.522 ERROR heat.engine.resource [-] ADOPT: ResourceGroup "rg" Stack "rd_adopt" [48860293-8e61-42d0-a333-ff4c2a252a77]
2014-08-07 14:53:56.522 TRACE heat.engine.resource Traceback (most recent call last):
2014-08-07 14:53:56.522 TRACE heat.engine.resource File "/opt/stack_master/heat/heat/engine/resource.py", line 404, in _action_recorder
2014-08-07 14:53:56.522 TRACE heat.engine.resource yield
2014-08-07 14:53:56.522 TRACE heat.engine.resource File "/opt/stack_master/heat/heat/engine/resource.py", line 449, in _do_action
2014-08-07 14:53:56.522 TRACE heat.engine.resource handle_data = (handle(resource_data) if resource_data else
2014-08-07 14:53:56.522 TRACE heat.engine.resource File "/opt/stack_master/heat/heat/engine/resource.py", line 553, in handle_adopt
2014-08-07 14:53:56.522 TRACE heat.engine.resource raise failure
2014-08-07 14:53:56.522 TRACE heat.engine.resource ResourceFailure: Exception: Resource ID was not provided.
2014-08-07 14:53:56.522 TRACE heat.engine.resource

[William C. Arnold (barnold-8)]

Saw this today while trying out the patches for https://bugs.launchpad.net/heat/+bug/1301314 "Abandon/adopt don't consider project", started debugging then spotted this bug report.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119355

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119355
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=fc8dd31ff79ba2c0c610e7a6fad450eb10acae93
Submitter: Jenkins
Branch: master

commit fc8dd31ff79ba2c0c610e7a6fad450eb10acae93
Author: Unmesh Gurjar <email address hidden>
Date: Thu Aug 21 14:28:49 2014 +0530

    Fixed adopt failure for stack with resource group

    Added support to adopt a resource group and corresponding
    unit test.

    Change-Id: Icfeff0e30a9c4bd7fa0279e156709e078b81fcab
    Closes-bug: #1353942