recent patch #99905 about REST retry is not work

[Qiming Teng]

Recent patch #99905 (https://review.openstack.org/#/c/99905/) breaks using 'requests=1.1.0'.

2014-08-07 14:09:41.079 ERROR ceilometer.alarm.service [-] Unable to notify alarm 705dca98-9243-4ce4-b216-068f67b44c14
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service Traceback (most recent call last):
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service File "/opt/stack/ceilometer/ceilometer/alarm/service.py", line 234, in _handle_action
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service current, reason, reason_data)
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service File "/opt/stack/ceilometer/ceilometer/alarm/notifier/rest.py", line 100, in notify
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service requests.adapters.HTTPAdapter(max_retries=max_retries))
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service TypeError: __init__() got an unexpected keyword argument 'max_retries'
2014-08-07 14:09:41.079 TRACE ceilometer.alarm.service

The requests.adapters.HTTPAdapter doesn't accept max_retries argument.

[Qiming Teng (tengqim)]

Further checking results:

https://github.com/kennethreitz/requests/commit/36dcce1a06fe0a82d8522c7d4287fb3623722c6c

The max_retries parameter was added on 13 Apr 2013, which means this patch needs a requests version of at least 1.2.1.

So, please bump requests version or rework this patch!

[Eoghan Glynn (eglynn)]

This may require an increase in the lower bound of the requests dependency in https://github.com/openstack/requirements/blob/master/global-requirements.txt#L113 to 1.2 and the corresponding update to the ceilometer requirements.txt.

[Rikimaru Honjo (honjo-rikimaru-c6)]

Thank you for suggesting.

Plan to fix this bug is following.

1. I push a patch that increase "requests" version in global-requirements.txt to "1.2.1".
2. After above patch will be merged, I push similar patch to ceilometer project.

If above plan contains some problems, please point it out.

[Rikimaru Honjo (honjo-rikimaru-c6)]

I pushed a following patch.

https://review.openstack.org/#/c/112721/

[Rikimaru Honjo (honjo-rikimaru-c6)]

Following patch was merged.

https://review.openstack.org/#/c/112721/

[Rikimaru Honjo (honjo-rikimaru-c6)]

Excuse me, please teach me what should I do to close this bug.

Should I also increase "requests" version in Ceilometer repository?
Otherwise, will "OpenStack Proposal bot" do it?