Use IDs in Selenium Tests When Possible

[Michael Jackson]

IDs are typically the most stable and fastest locators when using Selenium. The current Selenium integration tests are using CSS locators, even when unique IDs are available. We should consider using IDs as the standard, and switching the current CSS locators to IDs where possible. We may also consider adding IDs to the templates where it makes sense to help facilitate this in the testing.

[Gary W. Smith (gary-w-smith)]

Sounds like a reasonable change. Since id's must be unique, it may require some care in order to ensure that re-usable components generate unique ids.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/117619

[Tomáš Nováčik (tnovacik)]

@gary: IDs must be unique and they cannot be used on reusable components as this would ruin the whole idea of IDs.

[Wu Hong Guang (whg)]

The locator builder order by selenium IDE is :
id
link
name
css
xpath

It's ideal to use id to locate element when id is available

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/117619
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/155352

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/155352
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=02c6dab840afa20b0c6c3e3a8c35b86ef754314a
Submitter: Jenkins
Branch: master

commit 02c6dab840afa20b0c6c3e3a8c35b86ef754314a
Author: Martin Pavlasek <email address hidden>
Date: Thu Feb 12 16:08:22 2015 +0100

    Use IDs in locators instead of CSS when it is possible

    There were a lot of places that uses CSS_SELECTOR table#someid
    instead of just ID someid.

    Closes-Bug: 1353628
    Partially implements blueprint: selenium-integration-testing
    Change-Id: Ic6ac9b425976e60c067fc24e9819374c1a6080c2