duplicated check for router connect to external network

[Wei Wang]

In the function neutron.db.l3_db.get_assoc_data(),
we get router_id first, then check whether this router is connecting to external network.

But the function we used to get router_id -- neutron.db.l3_db._get_router_for_floatingip(), has already checked this.

As it names says, this function is designed for get router_id, which can connect to floating network.

[Wei Wang (damon-devops)]

So check at neutron.db.l3_db.get_assoc_data() is not necessary,
as soon as it confirmed, I'll submit a patch to review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/112349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112349
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03c4dc3573f640d06b80d686a389f1f3438a6d25
Submitter: Jenkins
Branch: master

commit 03c4dc3573f640d06b80d686a389f1f3438a6d25
Author: Wei Wang <email address hidden>
Date: Thu Aug 7 00:19:41 2014 +0800

    Remove duplicated check for router connect to external net

    In the function get_assoc_data, we check the router which get
    from _get_router_for_floatingip whether connect to external net,
    but as it has already checked in _get_router_for_floatingip.

    Change-Id: I0c00c480273145538d19569dc0a679e9935ad8f9
    Closes-bug: #1353414