Badrequest is considered an exception by wrong log level

Bug #1353328 reported by Haiwei Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Haiwei Xu

Bug Description

If a wrong key_name or image_name is configured in heat template, exception log level is used to report it like this:

2014-08-06 17:01:52.038 ERROR heat.engine.stack [req-eab9fec2-e890-4f8b-87eb-2147bc9ad8b8 demo demo] Property error : my_instance: key_name Error validating value u'my_ke': The Key (my_ke) could not be found.
2014-08-06 17:01:52.038 TRACE heat.engine.stack Traceback (most recent call last):
2014-08-06 17:01:52.038 TRACE heat.engine.stack File "/opt/stack/heat/heat/engine/stack.py", line 436, in validate
2014-08-06 17:01:52.038 TRACE heat.engine.stack result = res.validate()
2014-08-06 17:01:52.038 TRACE heat.engine.stack File "/opt/stack/heat/heat/engine/resources/server.py", line 871, in validate
2014-08-06 17:01:52.038 TRACE heat.engine.stack super(Server, self).validate()
2014-08-06 17:01:52.038 TRACE heat.engine.stack File "/opt/stack/heat/heat/engine/resource.py", line 703, in validate
2014-08-06 17:01:52.038 TRACE heat.engine.stack return self.properties.validate()
2014-08-06 17:01:52.038 TRACE heat.engine.stack File "/opt/stack/heat/heat/engine/properties.py", line 324, in validate
2014-08-06 17:01:52.038 TRACE heat.engine.stack raise exception.StackValidationFailed(message=msg)
2014-08-06 17:01:52.038 TRACE heat.engine.stack StackValidationFailed: Property error : my_instance: key_name Error validating value u'my_ke': The Key (my_ke) could not be found.
2014-08-06 17:01:52.038 TRACE heat.engine.stack

This is in fact an "info" level.

Haiwei Xu (xu-haiwei)
Changed in heat:
assignee: nobody → Haiwei Xu (xu-haiwei)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112237

Changed in heat:
status: New → In Progress
Revision history for this message
Visnusaran Murugan (visnusaran-murugan) wrote :

Error log is valid. Better to close this issue as invalid.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/112237
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3bcc695d3b29a7c429dffa291121c21724c3d668
Submitter: Jenkins
Branch: master

commit 3bcc695d3b29a7c429dffa291121c21724c3d668
Author: Haiwei Xu <email address hidden>
Date: Wed Aug 6 17:09:32 2014 +0900

    Fix wrong log level

    If a wrong key_name or image_name is configured in heat template,
    "exception" log level is used to report it. This should be the "info"
    level.

    Change-Id: I79122c22f2278e7c1a4e3daba70c122b78fb9aec
    Closes-Bug:#1353328

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.