guestagent/test_volume.py leaves a file hanging in /tmp

[Amrith Kumar]

trove/tests/unittests/guestagent/test_volume.py mocks execute() and then calls write_to_fstab().

However, since write_to_fstab() uses execute to delete the file, this leaves a turd in /tmp

Why we use execute() to delete files beats me ... python has a nice os.remove()

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/112118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112118
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=d5176723a5db62935323bc965964656a4ad2bec2
Submitter: Jenkins
Branch: master

commit d5176723a5db62935323bc965964656a4ad2bec2
Author: Amrith Kumar <email address hidden>
Date: Tue Aug 5 15:27:57 2014 -0400

    guestagent/test_volume.py leaves a file in /tmp

    Since the test mocks() execute and then calls write_to_fstab(), the
    file created in /tmp by write_to_fstab() stays around. This is because
    write_to_fstab() uses execute to remove the file. Replaced it with an
    os.remove() and fixed the test which was counting two calls to
    execute().

    I'm fixing it because testing for another bug involves running tox
    over and over again and leaving these files in /tmp is just a bit
    messy.

    Change-Id: Ia9e01049687644abd0671a658dffbbdcb4fba4bd
    Closes-Bug: #1353064