Terminal doesn't sanitize strings when reading/writing to dconf

Bug #1353010 reported by Raphael Isemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminal
Fix Released
Medium
Raphael Isemann

Bug Description

To reproduce:
Open terminal and close all tabs beside one.
Then:
$ cd
$ mkdir a,b a b # note: mkdir a,b with a comma between the letters
$ cd a,b

Close the terminal and reopen it

You have now two tabs in ~/a and ~/b instead of one tab in ~/a,b

Expected behavior:

One tab in ~/a,b

Relevant-code:
Line 533 in PantheonTerminalWindow.vala
tabs += t.get_shell_location () + ",";

Solution:

We shouldn't use a character for separating that is allowed in a path or do character-stuffing to escape relevant commas.

Related branches

Niclas Lockner (niclasl)
Changed in pantheon-terminal:
assignee: nobody → Raphael Isemann (teemperor)
milestone: none → freya-beta2
status: New → In Progress
importance: Undecided → Medium
David Gomes (davidgomes)
Changed in pantheon-terminal:
status: In Progress → Fix Committed
David Gomes (davidgomes)
Changed in pantheon-terminal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.