Filter the sources in parallel, so that we can remove source_max_weight parameter
Bug #1352851 reported by
Michele Simionato
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenQuake Engine |
Fix Released
|
High
|
Michele Simionato |
Bug Description
There is some cost here, since we will have to perform the filtering twice. Some performance test is in order.
Changed in oq-engine: | |
status: | In Progress → Fix Committed |
Changed in oq-engine: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
My analysis in real life use cases (especially the USA computations) shows that the duplication is negligible. For instance you may have 200,000 sources, 180,000 are filtered out, and therefore the duplicate filtering happens only for 20,000 sources, thus taking a negligible amount of time. On the other hand, the speedup is minor because a lot of the time is spend in transferring the sources back and forth. Still, it is worth doing because we can remove the parameter source_max_weight and keep only the parameter concurrent_tasks which is much more transparent to the end user.