QtMir

Initial surface size not decided by shell, but guessed by qtmir

Bug #1352845 reported by Gerry Boland
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
QtMir
In Progress
High
Gerry Boland
qtmir (Ubuntu)
In Progress
High
Gerry Boland
unity-api (Ubuntu)
In Progress
High
Gerry Boland
unity8 (Ubuntu)
In Progress
High
Gerry Boland

Bug Description

When a client connects to Mir and requests a surface with particular geometry, qtmir overrides the requested initial geometry with the width/height of the display. Once the surface has been drawn to, shell finally is notified of the surface and resizes it again.

These multiple resizes are bad. Shell should decide the initial geometry, instead of qtmir guessing it.

Related branches

lp:~gerboland/unity-api/surfaceSizerCallback
On hold for merging into lp:unity-api
Albert Astals Cid (community): Approve (code)
PS Jenkins bot (community): Approve (continuous-integration)
Michał Sawicz: Approve
Diff: 613 lines (+448/-6) (has conflicts)
11 files modified
debian/changelog (+41/-1)
include/unity/shell/application/ApplicationManagerInterface.h (+35/-0)
include/unity/shell/application/CMakeLists.txt (+2/-2)
include/unity/shell/application/Mir.h (+76/-0)
include/unity/shell/application/MirSurfaceInterface.h (+114/-0)
include/unity/shell/application/MirSurfaceItemInterface.h (+151/-0)
test/qmltest/mocks/plugins/Unity/Application/CMakeLists.txt (+1/-1)
test/qmltest/mocks/plugins/Unity/Application/Mocks/MockApplicationManager.cpp (+17/-1)
test/qmltest/mocks/plugins/Unity/Application/Mocks/MockApplicationManager.h (+4/-0)
test/qmltest/mocks/plugins/Unity/Launcher/CMakeLists.txt (+1/-1)
test/qmltest/unity/shell/application/tst_Application.qml (+6/-0)
lp:~gerboland/qtmir/initialSurfaceGeometry
On hold for merging into lp:qtmir
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Albert Astals Cid (community): Needs Fixing
Michał Sawicz: Approve
Daniel d'Andrada: Pending requested
Diff: 5503 lines (+1949/-1606)
45 files modified
CMakeLists.txt (+3/-1)
debian/changelog (+7/-0)
debian/control (+1/-1)
src/common/globals.h (+76/-0)
src/modules/Unity/Application/CMakeLists.txt (+2/-0)
src/modules/Unity/Application/application.cpp (+341/-69)
src/modules/Unity/Application/application.h (+61/-19)
src/modules/Unity/Application/application_manager.cpp (+118/-245)
src/modules/Unity/Application/application_manager.h (+22/-20)
src/modules/Unity/Application/applicationcontroller.h (+2/-1)
src/modules/Unity/Application/applicationscreenshotprovider.cpp (+1/-1)
src/modules/Unity/Application/mirsurfaceitem.cpp (+25/-25)
src/modules/Unity/Application/mirsurfaceitem.h (+21/-78)
src/modules/Unity/Application/mirsurfaceiteminterface.h (+89/-0)
src/modules/Unity/Application/mirsurfaceitemmodel.h (+2/-2)
src/modules/Unity/Application/mirsurfacemanager.cpp (+6/-6)
src/modules/Unity/Application/mirsurfacemanager.h (+4/-4)
src/modules/Unity/Application/plugin.cpp (+30/-32)
src/modules/Unity/Application/session.cpp (+123/-73)
src/modules/Unity/Application/session.h (+15/-8)
src/modules/Unity/Application/session_interface.h (+31/-23)
src/modules/Unity/Application/sessionmanager.cpp (+2/-2)
src/modules/Unity/Application/sessionmanager.h (+3/-1)
src/modules/Unity/Application/taskcontroller.cpp (+8/-13)
src/modules/Unity/Application/taskcontroller.h (+4/-6)
src/modules/Unity/Application/upstart/applicationcontroller.cpp (+10/-2)
src/platforms/mirserver/CMakeLists.txt (+2/-0)
src/platforms/mirserver/mirserver.cpp (+1/-2)
src/platforms/mirserver/mirshell.cpp (+28/-23)
src/platforms/mirserver/mirshell.h (+16/-12)
tests/modules/Application/CMakeLists.txt (+5/-0)
tests/modules/Application/application_test.cpp (+145/-71)
tests/modules/ApplicationManager/CMakeLists.txt (+5/-1)
tests/modules/ApplicationManager/application_manager_test.cpp (+410/-831)
tests/modules/MirSurfaceItem/CMakeLists.txt (+3/-1)
tests/modules/MirSurfaceItem/mirsurfaceitem_test.cpp (+1/-1)
tests/modules/SessionManager/CMakeLists.txt (+4/-0)
tests/modules/SessionManager/session_manager_test.cpp (+1/-1)
tests/modules/SessionManager/session_test.cpp (+57/-24)
tests/modules/TaskController/CMakeLists.txt (+1/-0)
tests/modules/common/fake_mirsurfaceitem.h (+95/-0)
tests/modules/common/mock_mirsurfaceitem.h (+50/-0)
tests/modules/common/mock_session.h (+44/-5)
tests/modules/common/qtmir_test.cpp (+61/-0)
tests/modules/common/qtmir_test.h (+13/-2)
lp:~gerboland/unity8/initialSurfaceGeometry
On hold for merging into lp:unity8
Albert Astals Cid (community): Needs Fixing
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Michał Sawicz: Approve
Daniel d'Andrada: Pending requested
Diff: 190 lines (+72/-3)
8 files modified
debian/control (+2/-2)
qml/Stages/PhoneStage.qml (+13/-0)
qml/Stages/TabletStage.qml (+21/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+20/-0)
tests/mocks/Unity/Application/ApplicationManager.h (+4/-0)
tests/plugins/Unity/Launcher/CMakeLists.txt (+1/-1)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+2/-0)
tests/qmltests/Stages/tst_PhoneStage.qml (+9/-0)
Gerry Boland (gerboland)
Changed in qtmir:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Gerry Boland (gerboland)
Revision history for this message
Florian Boucault (fboucault) wrote :

The worst offenders are from best to worst: sudoku app, music app, shorts app.

Gerry Boland (gerboland)
Changed in qtmir:
status: Confirmed → In Progress
Revision history for this message
Michał Sawicz (saviq) wrote :
Download full text (3.8 KiB)

We had to pull this, unfortunately there's a seldom, but still, deadlock when using this approach:

Thread 9 (Thread 0xaebff450 (LWP 15260)):
#0 0xb603f554 in __libc_do_syscall () from /lib/arm-linux-gnueabihf/libpthread.so.0
#1 0xb603b192 in pthread_cond_wait@@GLIBC_2.4 () from /lib/arm-linux-gnueabihf/libpthread.so.0
#2 0xb63b3794 in QWaitCondition::wait(QMutex*, unsigned long) ()
   from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#3 0xb63aed2e in QSemaphore::acquire(int) () from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#4 0xb6525436 in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/lib/arm-linux-gnueabihf/libQt5Core.so.5
#5 0xb4001384 in MirPlacementStrategy::sessionAboutToCreateSurface(mir::scene::Session const&, QSize&) ()
   from /usr/lib/arm-linux-gnueabihf/qt5/plugins/platforms/libqpa-mirserver.so
#6 0xb3ff239e in MirPlacementStrategy::place(mir::scene::Session const&, mir::scene::SurfaceCreationParameters const&) () from /usr/lib/arm-linux-gnueabihf/qt5/plugins/platforms/libqpa-mirserver.so
#7 0xb3e96f3e in mir::scene::SurfaceController::add_surface(mir::scene::SurfaceCreationParameters const&, mir::scene::Session*) () from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#8 0xb3e81646 in mir::scene::ApplicationSession::create_surface(mir::scene::SurfaceCreationParameters const&)
    () from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#9 0xb3eb2a5c in mir::frontend::SessionMediator::create_surface(google::protobuf::RpcController*, mir::protobuf::SurfaceParameters const*, mir::protobuf::Surface*, google::protobuf::Closure*) ()
   from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#10 0xb3eb6228 in void mir::frontend::detail::invoke<mir::frontend::detail::ProtobufMessageProcessor, mir::frontend::detail::DisplayServer, mir::protobuf::DisplayServer, mir::protobuf::SurfaceParameters, mir::protobuf::Surface>(mir::frontend::detail::ProtobufMessageProcessor*, mir::frontend::detail::DisplayServer*, void (mir::protobuf::DisplayServer::*)(google::protobuf::RpcController*, mir::protobuf::SurfaceParameters const*, mir::protobuf::Surface*, google::protobuf::Closure*), mir::frontend::detail::Invocation const&) ()
   from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#11 0xb3eb4f6a in mir::frontend::detail::ProtobufMessageProcessor::dispatch(mir::frontend::detail::Invocation const&) () from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#12 0xb3ebb44c in mir::frontend::detail::SocketConnection::on_new_message(boost::system::error_code const&) ()
   from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#13 0xb3ebb732 in mir::frontend::detail::SocketConnection::on_read_size(boost::system::error_code const&) ()
   from /usr/lib/arm-linux-gnueabihf/libmirserver.so.24
#14 0xb3ebd75a in boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::local::stream_protocol, boost::asio::stream_socket_service<boost::asio::local::stream_protocol> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_exactly_t, std::function<void (boost::system::error_code const&, unsigned int)> > >::do_complete(boost::asio::detail::tas...

Read more...

kevin gunn (kgunn72)
Changed in unity-api (Ubuntu):
assignee: nobody → Gerry Boland (gerboland)
Changed in unity8 (Ubuntu):
assignee: nobody → Gerry Boland (gerboland)
Changed in qtmir (Ubuntu):
assignee: nobody → Gerry Boland (gerboland)
status: New → In Progress
Changed in unity8 (Ubuntu):
status: New → In Progress
Changed in unity-api (Ubuntu):
status: New → In Progress
Changed in qtmir (Ubuntu):
importance: Undecided → High
Changed in unity8 (Ubuntu):
importance: Undecided → High
Changed in unity-api (Ubuntu):
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.