router-update fails with 500 for dvr routers

[Preethi Dsilva]

1.create a dvr with name say dvr1
2.add router gateway
3.now perform router update neutron router-update dvr1 --name dvr2
Actual Results:
Request Failed: internal server error while processing your request" error is seen,trace related to L3RouterPlugin logs are seen
Expected Results:
router name should be updated

[Santosh Kumar (santosh-kumar4)]

Hi Preeti ,

I have executed the same use case on my icehouse setup , however problem is not reproducible :

1. Created Netwrok :

root@osc:/home/sdn# neutron net-create --router:external=True n1
Created a new network:
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| id | d2f3bc3b-e744-4ff6-a3ea-1d88d9477f02 |
| name | n1 |
| provider:network_type | vxlan |
| provider:physical_network | |
| provider:segmentation_id | 2663 |
| router:external | True |
| shared | False |
| status | ACTIVE |
| subnets | |
| tenant_id | 13221882707a4c4d8e0ee7ae3c1be491 |
+---------------------------+--------------------------------------+

2. Created Subnet :

root@osc:/home/sdn# neutron subnet-create n1 1.1.1.0/24
Created a new subnet:
+------------------+------------------------------------------+
| Field | Value |
+------------------+------------------------------------------+
| allocation_pools | {"start": "1.1.1.2", "end": "1.1.1.254"} |
| cidr | 1.1.1.0/24 |
| dns_nameservers | |
| enable_dhcp | True |
| gateway_ip | 1.1.1.1 |
| host_routes | |
| id | e09e957e-411e-4fec-adc0-45dbd1a2f365 |
| ip_version | 4 |
| name | |
| network_id | d2f3bc3b-e744-4ff6-a3ea-1d88d9477f02 |
| tenant_id | 13221882707a4c4d8e0ee7ae3c1be491 |
+------------------+------------------------------------------+

3. Set Router Gateway :

root@osc:/home/sdn# neutron router-gateway-set r1 n1
Set gateway for router r1

4. Updated router name

root@osc:/home/sdn# neutron router-update --name=r2 r1
Updated router: r1

( It works fine )

root@osc:/home/sdn# neutron router-list
+--------------------------------------+-----------+-----------------------------------------------------------------------------+
| id | name | external_gateway_info |
+--------------------------------------+-----------+-----------------------------------------------------------------------------+
| 4c3209c5-b154-4973-8f1d-513075594f18 | hyt-r-000 | null |
| 7bb46b0c-e93a-4174-b785-0773469c9b0e | r2 | {"network_id": "d2f3bc3b-e744-4ff6-a3ea-1d8...

[Armando Migliaccio (armando-migliaccio)]

I have tried to reproduce this on master and I am unable to reproduce too. Is there some steps you have missed to report?

[Armando Migliaccio (armando-migliaccio)]

It turns out I was using a different branch. I confirm this stacktrace:

http://paste.openstack.org/show/90499/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/112053

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112053
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c5e186f466a4347b72868db8adbde9450215f107
Submitter: Jenkins
Branch: master

commit c5e186f466a4347b72868db8adbde9450215f107
Author: armando-migliaccio <email address hidden>
Date: Tue Aug 5 08:56:23 2014 -0700

    Fix 500 error during router-update for dvr routers

    This was caused because the l3 service plugin was
    erroneously calling a method on self, whereas the
    method is implemented by the core plugin.

    Closes-bug: #1352786

    Change-Id: I0746eee314730370b2df4bef6d9fd41680e2e3d1