Facebook app banner is back

Bug #1352783 reported by Olivier Tilloy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Bill Filler
webbrowser-app (Ubuntu)
Fix Released
Medium
Ugo Riboni

Bug Description

The Ubuntu WebView component comes preloaded with a user script that removes the app banner that facebook displays on its login page to advertise its native android application (see http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Web/fb-no-appbanner.js).

Facebook changed recently their login page layout, and the script stopped working. The banner used to be enclosed in a div with class "appBanner", which made it easy to detect and suppress. It no longer has this class, here is what the code looks like now:

  <div class="_4fmw grouped aclb">
    <a class="touchableArea first last area touchable acy apl abt abb" href="https://m.facebook.com/click.php?redir_url=market%3A%2F%2Fdetails%3Fid%3Dcom.facebook.katana&amp;app_id=350685531728&amp;cref=mb&amp;no_fw=1&amp;refid=8" target="_top" data-sigil="touchable marea">
      <div class="ib">
        <i class="l img sp_L9H7wTVnopj sx_a37e0f"></i>
        <div class="c">
          <span class="fcl">Get Facebook for Android and browse faster.</span>
        </div>
      </div>
    </a>
  </div>

Related branches

Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Triaged
Changed in webbrowser-app (Ubuntu RTM):
status: New → Triaged
Changed in webbrowser-app (Ubuntu):
importance: Undecided → Medium
Changed in webbrowser-app (Ubuntu RTM):
importance: Undecided → Medium
no longer affects: webbrowser-app
Olivier Tilloy (osomon)
no longer affects: webbrowser-app (Ubuntu RTM)
Ugo Riboni (uriboni)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Ugo Riboni (uriboni)
status: Triaged → In Progress
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

in silo 39 - ready for qa

Changed in canonical-devices-system-image:
importance: Undecided → Medium
milestone: none → ww46-2015
status: New → In Progress
assignee: nobody → Bill Filler (bfiller)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151103-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151103-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Update translation template.

  [ Ugo Riboni ]
  * Fix a bug preventing in some cases the address bar from getting
    focus when entering find in page mode. Also correctly hide the left
    hand side icons when in find in page mode. (LP: #1508130)
  * Focus the page when opening links with target="_blank". (LP:
    #1505724)
  * Prevent the address bar from being cleared when the actual url
    changes and the user has already started typing. (LP: #1487713)
  * Update the user script to remove the Facebook app banner. (LP:
    #1352783)
  * Use AbstractButton to handle some tab interactions so that haptics
    are used on touch. (LP: #1505725)

 -- Olivier Tilloy <email address hidden> Tue, 03 Nov 2015 11:56:19 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.