innoback up should check the existence of rsync

[Matthew B]

So, if you specify -rsync, innobackup should check that exists BEFORE starting the backup process. Very rude awakening to come back to a backup session hours later and discover it failed because the sysadmin forgot to install it.

140804 21:22:53 Starting rsync as: rsync -t "/db/mysql-data" --files-from="/db/mysql-tmpdir/xtrabackup_rsyncfiles_pass2" "/var/mysql/2014-08-04_21-17-56"
sh: rsync: command not found
innobackupex: Error: rsync failed: No such file or directory at /usr/bin/innobackupex line 3999.

This is a simple sanity check. In fact, all checks should happen first, like the existence of tar or gzip or xbstream.

[Nilnandan Joshi (nilnandan-joshi)]

Confirmed with 2.2.3. Even rysnc is not found still, giving msg that " rsync finished successfully."

root@nilnandan-Dell-XPS:/var/lib/mysql# xtrabackup --version
xtrabackup version 2.2.3 based on MySQL server 5.6.17 Linux (x86_64) (revision id: )
root@nilnandan-Dell-XPS:/var/lib/mysql#

root@nilnandan-Dell-XPS:/var/lib/mysql# innobackupex --user=root --password=root --rsync /home/nilnandan/backup

InnoDB Backup Utility v1.5.1-xtrabackup; Copyright 2003, 2009 Innobase Oy
and Percona LLC and/or its affiliates 2009-2013. All Rights Reserved.

...
140819 14:11:45 Starting rsync as: rsync -t "/var/lib/mysql" --files-from="/tmp/xtrabackup_rsyncfiles_pass1" "/home/nilnandan/backup/2014-08-19_14-11-38"
sh: 1: rsync: not found
140819 14:11:45 rsync finished successfully.
...
innobackupex: Backing up file '/var/lib/mysql/percona/checksums.frm'
innobackupex: Backing up files '/var/lib/mysql/mysql/*.{frm,isl,MYD,MYI,MAD,MAI,MRG,TRG,TRN,ARM,ARZ,CSM,CSV,opt,par}' (74 files)
innobackupex: Backing up files '/var/lib/mysql/performance_schema/*.{frm,isl,MYD,MYI,MAD,MAI,MRG,TRG,TRN,ARM,ARZ,CSM,CSV,opt,par}' (53 files)
140819 14:11:45 Starting rsync as: rsync -t "/var/lib/mysql" --files-from="/tmp/xtrabackup_rsyncfiles_pass2" "/home/nilnandan/backup/2014-08-19_14-11-38"
>> log scanned up to (20284873353)
sh: 1: rsync: not found
innobackupex: Error: rsync failed: No such file or directory at /usr/bin/innobackupex line 4149.
140819 14:11:45 innobackupex: Waiting for ibbackup (pid=29996) to finish
root@nilnandan-Dell-XPS:/var/lib/mysql#

[Alexey Kopytov (akopytov)]

See also bug #1259436. Which is different in scope, but should solve the problem for people using distribution packages rather than tarballs. Raising the priority for bug #1259436 and keeping this one as a low priority bug.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-921