Use resume_guests instead of start_guests

[Damia Pastor]

By default the option: Start guests on host boot, on fuel is active, which I think is the same thing as in nova.conf:

start_guests_on_host_boot=true

I don't think this is a good idea in production with multiple tenants, as if I stopped or paused a vm, there might be a good reason for it.

I understand that the user might want to have all the vms that were running before started again, for that reason there is this option:

resume_guests_state_on_host_boot=True

My suggestion is to change the first option for the second one, or at least add the second one to the configuration options.

http://docs.openstack.org/grizzly/openstack-compute/admin/content/list-of-compute-config-options.html

[Mike Scherbakov (mihgen)]

Fix should be simple modification of puppet nova.conf template (fuel-library repo) & release info in openstack.yaml (fuel-web repo) - to reflect it in UI too.

[Michał Frontczak (michaljev)]

Hi, I would like to work on this bug

[Michał Frontczak (michaljev)]

Hi, so I forked fuel-web and fuel-library on github and I can't find nova.conf there is only one file with similar name but I don't think it is the right one.

[Michał Frontczak (michaljev)]

where can I find nova.conf file ?

[Christopher Aedo (docaedo)]

Since nova.conf is built dynamically you need to make the changes to the puppet manifests, looks like in fuel-library that would be in:
fuel-library/deployment/puppet/osnailyfacter/manifests/cluster_ha.pp
fuel-library/deployment/puppet/osnailyfacter/manifests/cluster_ha_full.pp
fuel-library/deployment/puppet/osnailyfacter/manifests/cluster_simple.pp

Couple that with the matching adjustments in fuel-web:
fuel-web/nailgun/nailgun/fixtures/openstack.yaml

and you should be good to go.

[Michał Frontczak (michaljev)]

Thank you :)

[Christopher Aedo (docaedo)]

No updates in almost a month, I'll try to move it forward. Let me know if you've had any progress since the last update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124206

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124206
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=62c1c40b090f604fbdcaf9132741b5ff7a24d9b5
Submitter: Jenkins
Branch: master

commit 62c1c40b090f604fbdcaf9132741b5ff7a24d9b5
Author: Christopher Aedo <email address hidden>
Date: Thu Sep 25 15:28:54 2014 -0700

    Replace start_guests with resume_guests

    Fuel UI offers an option to "start guests on reboot" which,
    if set to true, will attempt to restart all guests on a
    given host regardless of prior status. This commit changes
    the nova.conf entry from start_guests_on_boot to
    resume_guets_state_on_host_boot.

    Depends on https://review.openstack.org/#/c/124207/ in fuel-library

    Change-Id: Ib7515b760fff08226de887748e611030ae101a50
    Partial-Bug: #1352284

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124207
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=8a3c19054d3d75185d3fd112104ee6e6d7c005a0
Submitter: Jenkins
Branch: master

commit 8a3c19054d3d75185d3fd112104ee6e6d7c005a0
Author: Christopher Aedo <email address hidden>
Date: Thu Sep 25 15:32:03 2014 -0700

    Replace start_guests with resume_guests

    Fuel UI offers an option to "start guests on reboot" which,
    if set to true, will attempt to restart all guests on a
    given host regardless of prior status. This commit changes
    the nova.conf entry from start_guests_on_boot to
    resume_guets_state_on_host_boot.

    Change-Id: I3515c6350c1314cf091480ea109c8ade6195ea17
    Partial-Bug: #1352284

[Aleksandr Didenko (adidenko)]

https://review.openstack.org/124207 changes nova_config for 'controller' role, not for 'compute'. So on 6.0 and master branches compute nodes do not have either start_guests_on_boot or resume_guets_state_on_host_boot option in their nova.conf files:

2015-01-21 02:03:22 -0800 /Stage[main]/Osnailyfacter::Cluster_simple/Nova_config[DEFAULT/start_guests_on_host_boot] (info): Starting to evaluate the resource
2015-01-21 02:03:22 -0800 /Stage[main]/Osnailyfacter::Cluster_simple/Nova_config[DEFAULT/start_guests_on_host_boot] (debug): Nothing to manage: no ensure and the resource doesn't exist
2015-01-21 02:03:22 -0800 /Stage[main]/Osnailyfacter::Cluster_simple/Nova_config[DEFAULT/start_guests_on_host_boot] (info): Evaluated in 0.00 seconds

Changing status back to confirmed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148871

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/148872

[OpenStack Infra (hudson-openstack)]

Change abandoned by Aleksandr Didenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/148871
Reason: Superseded by granular deployment

[Aleksandr Didenko (adidenko)]

For master (6.1) fix is already merged in https://review.openstack.org/#/c/148879/14

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148872
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=8fc7fd842c1cbab7953b00bd5769259d6e31ba1a
Submitter: Jenkins
Branch: stable/6.0

commit 8fc7fd842c1cbab7953b00bd5769259d6e31ba1a
Author: Aleksandr Didenko <email address hidden>
Date: Wed Jan 21 12:38:28 2015 +0200

    Replace start_guests with resume_guests

    This commit changes the nova.conf entry from start_guests_on_boot
    to resume_guets_state_on_host_boot for compute nodes.

    Change-Id: I5c6835f3852eae90ed40429635ff38d36e256c6c
    Partial-Bug: #1352284

[Alexander Nevenchannyy (anevenchannyy)]

Verified on MOS 6.1 ISO #429
Steps to Verify:
root@node-4:~# grep resume_guests_state_on_host_boot /etc/nova/nova.conf
resume_guests_state_on_host_boot=True