[System tests] Need to refactor Network verification methods

Bug #1352217 reported by Andrey Sledzinskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Andrey Sledzinskiy

Bug Description

In fuel_web_client.py we have two the same methods - 'verify_network' and 'run_network_verify' and we use these methods in different tests.
I think we should keep only 'verify_network' method and replace 'run_network_verify' in tests because now we have to change some parameters in both methods

Tags: system-tests
Changed in fuel:
status: New → Confirmed
Changed in fuel:
status: Confirmed → Invalid
status: Invalid → Confirmed
Changed in fuel:
milestone: 5.1 → 6.0
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Andrey Sledzinskiy (asledzinskiy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112048

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/112048
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=124ea87f1ac1c06e27613fe3b31fd5fc6b39e82d
Submitter: Jenkins
Branch: master

commit 124ea87f1ac1c06e27613fe3b31fd5fc6b39e82d
Author: asledzinskiy <email address hidden>
Date: Tue Aug 5 18:35:09 2014 +0300

    Refactor network verification method

    - Add default timeout to verify_network method
    - Change run_network_verify to verify_netwrok in tests

    Change-Id: I7631145380f1443117c15519dada5232d9b23217
    Closes-Bug: #1352217

Changed in fuel:
status: In Progress → Fix Committed
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
Dima Shulyak (dshulyak) wrote :

Right now all false tests, like simple_flat_blocked_vlan, are broken

Changed in fuel:
status: Fix Released → Confirmed
importance: Medium → High
milestone: 6.0 → 5.1
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

it isn't absolutely related to this issue. we just refactored our code for use one method.

Changed in fuel:
status: Confirmed → Fix Committed
Dima Shulyak (dshulyak)
Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112851

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/112851
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=71d087af48ee2b48206e46981d473f3d826ccf75
Submitter: Jenkins
Branch: master

commit 71d087af48ee2b48206e46981d473f3d826ccf75
Author: asledzinskiy <email address hidden>
Date: Fri Aug 8 15:46:27 2014 +0300

    Refactor verify network method

    - Add 'success' parameter that is true by default
    - Modify verify network method call in tests where it
    should fail

    Change-Id: I115d7fd909d627d92b1811baebcd776b49e1af11
    Closes-Bug: #1352217

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/112912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (stable/5.0)

Reviewed: https://review.openstack.org/112912
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=87f8c05d39cb4457a458121d9a30bcab9fde4c52
Submitter: Jenkins
Branch: stable/5.0

commit 87f8c05d39cb4457a458121d9a30bcab9fde4c52
Author: asledzinskiy <email address hidden>
Date: Tue Aug 5 18:35:09 2014 +0300

    Refactor network verification method

    - Add default timeout to verify_network method
    - Add success parameter to verify_network method
    - Change run_network_verify to verify_netwrok in tests

    Change-Id: I7631145380f1443117c15519dada5232d9b23217
    Closes-Bug: #1352217

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.