connector.py is calling iscsiadm 3 times instead of 1 when CHAP is enabled

[Yaniv Kaul]

From brick/initiator/connector.py :
        if connection_properties.get('auth_method'):
            self._iscsiadm_update(connection_properties,
                                  "node.session.auth.authmethod",
                                  connection_properties['auth_method'])
            self._iscsiadm_update(connection_properties,
                                  "node.session.auth.username",
                                  connection_properties['auth_username'])
            self._iscsiadm_update(connection_properties,
                                  "node.session.auth.password",
                                  connection_properties['auth_password'])

This is inefficient - there is no reason why not call iscsiadm and update all 3 parameters in one call. Multiple '-n' ... '-v'... can be used.
There is no situation in which only one of the parameters will be updated - they are all updated at once.

[John Griffith (john-griffith)]

Certainly poor, and certainly can/should be improved but wouldn't consider this a bug.

[Yaniv Kaul (yaniv-kaul)]

John, how is making this invalid improving the situation? If it's not a bug, what is ? A feature?

[John Griffith (john-griffith)]

Yaniv,
What's making it better is the code that I'm currently writing that consolidates it.

What's making it better is defining what a "bug" is... IMO this is poor code and inefficient, however it's perfectly functional.

I can make it triaged and wish list which in fact may be more appropriate.

Thanks

[Yaniv Kaul (yaniv-kaul)]

Thanks John,

Note that while I found this while looking at the code, I was doing it while trying to run scale up tests (run as many VMs on a single host, running against a fast Cinder-based storage).

[Rebecca Finn (rebeccax-finn)]

This section and file no longer exist, so I don't think that this bug is still valid.