Backup/restore namespace config move leaves duplicates in DEFAULT too

Bug #1351545 reported by Mark Kirkwood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Amrith Kumar

Bug Description

Commit 61935d3 has moved backup_namespace and restore_namespace from the default conf group to per datastore. However they still appear in the common_opts section of trove/common/cfg.py. This should be fixed, either by removing these entries from common_opts or marking them as deprecated.

I also note that some datastores have not been blessed with these config variables at all (redis, mongo, cassandra) - I'd guess that these may need 'em set too?

Revision history for this message
Amrith Kumar (amrith) wrote :

fix is on the way.

Changed in trove:
assignee: nobody → Amrith (amrith)
Amrith Kumar (amrith)
Changed in trove:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112995

Changed in trove:
status: Confirmed → In Progress
Revision history for this message
Amrith Kumar (amrith) wrote :

backup_strategy follows the same pattern and it will be cleaned up as well [review comment]

Changed in trove:
milestone: none → juno-3
Changed in trove:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/112995
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a79927fe6edb875d5471fab3c84887cccf927cd1
Submitter: Jenkins
Branch: master

commit a79927fe6edb875d5471fab3c84887cccf927cd1
Author: Amrith Kumar <email address hidden>
Date: Fri Aug 8 14:24:17 2014 -0400

    Deprecate unused entries in cfg.py

    backup_namespace and restore_namespace are now referenced on a
    per-datastore basis. Having them in the common options is now no
    longer useful. Deleted them from the common_options and marked them as
    deprecated in the datastores.

    Change-Id: I2d021d68c483b77f9426d78685a06fb0733ec5e9
    Closes-Bug: #1351545

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.