periodic_last_run missing

[Ghe Rivero]

2014-07-31 22:15:08.783 29553 ERROR ironic.openstack.common.loopingcall [-] in dynamic looping call
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall Traceback (most recent call last):
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall File "/opt/stack/new/ironic/ironic/openstack/common/loopingcall.py", line 124, in _inner
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall idle = self.f(*self.args, **self.kw)
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall File "/opt/stack/new/ironic/ironic/conductor/manager.py", line 211, in periodic_tasks
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall return self.run_periodic_tasks(context, raise_on_error=raise_on_error)
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall File "/opt/stack/new/ironic/ironic/openstack/common/periodic_task.py", line 182, in run_periodic_tasks
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall last_run = self._periodic_last_run[task_name]
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall AttributeError: 'ConductorManager' object has no attribute '_periodic_last_run'
2014-07-31 22:15:08.783 29553 TRACE ironic.openstack.common.loopingcall

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111126

[Roman Prykhodchenko (romcheg)]

Ghe, could you please tell how to reproduce it? I cannot see logs like that in my setup.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111126
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=df41f0b538f69545dbe4d085ab277593d24eb6b2
Submitter: Jenkins
Branch: master

commit df41f0b538f69545dbe4d085ab277593d24eb6b2
Author: Ghe Rivero <email address hidden>
Date: Fri Aug 1 01:12:00 2014 +0000

    Fix not attribute '_periodic_last_run'

    The ConductorManager class wasn't calling __init__ from
    its parent object, causing an AttributeError exception
    to be raised when accessing the attribute _periodic_last_run.
    This attribute was initialized in the PeriodicTasks class.

    Change-Id: Ieb850bf448f4b04be33c2cfecbac2de5925d6fda
    Closes-Bug: #1351114

[Ghe Rivero (ghe.rivero)]

This attribute error will raise when the recent oslo.incubator modules land in ironic. There is a patch on the way for that.