lxml is a hard dependency even if XmlBodyMiddleware is not enabled

[werner mendizabal]

When XmlBodyMiddleware is not enabled in keystone-paste.ini
keystone will still require lxml to be installed.

https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/middleware/core.py#L150

https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/middleware/core.py#L190

https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/middleware/core.py#L198

[Lance Bragstad (lbragstad)]

Looks like the XmlBodyMiddleware is planned to be removed in Kilo?

Also, I think the main problem here is due to the import chain:

https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/middleware/core.py#L20 which in turn imports https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/common/serializer.py#L23 regardless

[Lance Bragstad (lbragstad)]

In addition to comment 1, XmlBodyMiddleware is deprecated and planned to be removed in Kilo, according to:

https://github.com/openstack/keystone/blob/a617408a7ba441b46fc618a86501adbcaa403dd9/keystone/middleware/core.py#L153-L157

and...

https://github.com/openstack/keystone/commit/e2af13f87e63f4a4e4d04712cc811d65d47cff5e

[werner mendizabal (nonameentername)]

These are the config options that I changed:
http://paste.openstack.org/show/89458/

This is the error I get when starting keystone:
http://paste.openstack.org/show/89459/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111108

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111108
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ed1b10f280452b73b29d417575fd6b32268a55bd
Submitter: Jenkins
Branch: master

commit ed1b10f280452b73b29d417575fd6b32268a55bd
Author: werner mendizabal <email address hidden>
Date: Thu Jul 31 17:50:57 2014 -0500

    Refactor serializer import to XmlBodyMiddleware

    Previously, the keystone/middleware/core.py module would import
    keystone/common/serializer.py regardless of the XmlBodyMiddleware class
    being used. This change modifies keystone/common/serializer.py to raise
    an error if there is an issue with using lxml at runtime.

    Change-Id: I977275d0df8666b49ddbfadd4f5606d7c2292b1f
    Closes-Bug: 1351016

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113255

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/113255
Reason: abandoning in favor of: https://review.openstack.org/#/c/112914/