add/delete fixed ip fails with nova-network

[Oleg Bondarev]

nova add-fixed-ip <server> <network> fails with following in compute log:

2014-07-31 06:01:48.697 ERROR oslo.messaging.rpc.dispatcher [req-6e04dd42-1ebe-4aa3-a37b-e84bb60b3413 admin demo] Exception during message handling: 'dict' object has no attribute 'get_meta'
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_reply
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher incoming.message))
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/compute/manager.py", line 414, in decorated_function
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher return function(self, context, *args, **kwargs)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/exception.py", line 88, in wrapped
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher payload)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/exception.py", line 71, in wrapped
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher return f(self, context, *args, **kw)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/compute/manager.py", line 327, in decorated_function
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher kwargs['instance'], e, sys.exc_info())
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/compute/manager.py", line 315, in decorated_function
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher return function(self, context, *args, **kwargs)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/compute/manager.py", line 3737, in add_fixed_ip_to_instance
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher self._inject_network_info(context, instance, network_info)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/compute/manager.py", line 4091, in _inject_network_info
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher network_info)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/virt/libvirt/driver.py", line 5383, in inject_network_info
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher self.firewall_driver.setup_basic_filtering(instance, nw_info)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/virt/libvirt/firewall.py", line 286, in setup_basic_filtering
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher self.nwfilter.setup_basic_filtering(instance, network_info)
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/nova/nova/virt/libvirt/firewall.py", line 123, in setup_basic_filtering
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher if subnet.get_meta('dhcp_server'):
2014-07-31 06:01:48.697 TRACE oslo.messaging.rpc.dispatcher AttributeError: 'dict' object has no attribute 'get_meta'

same happens with remove-fixed-ip call

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110973
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=984f4192ede99951078e2f6091e4c3e26cdb0e01
Submitter: Jenkins
Branch: master

commit 984f4192ede99951078e2f6091e4c3e26cdb0e01
Author: Oleg Bondarev <email address hidden>
Date: Thu Jul 31 17:59:11 2014 +0400

    Return hydrated net info from novanet add/remove_fixed_ip calls

    Compute manager expects hydrated network info from network_api

    Change-Id: I36e48742144555004cbd1f71429a943c7e2952b0
    Closes-bug: #1350846