Scope ini file is expected in the wrong location
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Undecided
|
Pete Woods |
Bug Description
Following the apparmor policy updates a little while ago, scopes are now named after the hook short ID.
For a scope package "package-name" with a hook "hook-name" to the directory "dir-name".
manifest.json:
{
...
"hooks": {
"HOOKNAME": {
}
},
"name": "PACKAGENAME"
...
}
The tool should look in
DIRNAME/
for the the ini file.
It is currently looking in
DIRNAME/
which is incorrect.
Additionally, the validation rules for the ini file itself are incomplete and incorrect. Please see the documentation at http://
Related branches
- Jamie Strandboge (community): Approve
- Daniel Holbach: Pending requested
- Canonical Store Reviewers: Pending requested
-
Diff: 146 lines (+34/-33)2 files modifiedclickreviews/cr_scope.py (+20/-11)
clickreviews/tests/test_cr_scope.py (+14/-22)
description: | updated |
description: | updated |
description: | updated |
Changed in click-reviewers-tools: | |
assignee: | nobody → Pete Woods (pete-woods) |
status: | New → Fix Committed |
tags: | added: scope-dev |
Changed in click-reviewers-tools: | |
status: | Fix Committed → Fix Released |