[Bootstrap][data processing] Problems with form behavior and button icons

Bug #1350372 reported by Chad Roberts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Nikita Konovalov

Bug Description

The Sahara (data processing) UI has a few issues after the bootstrap 3 merge:

Problem: Some forms have "extra" fields that are showing up at inappropriate times.
Cause: Javascript that relied on "control-group" need to change to use "form-group".
Affected panels:
clusters, data sources, job binaries, job executions, jobs, nodegroup templates

Problem: Buttons on some forms are missing button shape (usually cancel).
Cause: btn-default class is not applied on those buttons

Tags: bootstrap
Chad Roberts (croberts)
tags: added: bootstrap
Changed in horizon:
assignee: nobody → Chad Roberts (croberts)
Chad Roberts (croberts)
description: updated
Chad Roberts (croberts)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110680

Changed in horizon:
status: New → In Progress
Chad Roberts (croberts)
description: updated
Changed in horizon:
assignee: Chad Roberts (croberts) → Nikita Konovalov (nkonovalov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/110680
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=82fb7286c5ee6f89abcba2cf628b37d242d5a6a3
Submitter: Jenkins
Branch: master

commit 82fb7286c5ee6f89abcba2cf628b37d242d5a6a3
Author: Chad Roberts <email address hidden>
Date: Wed Jul 30 11:28:38 2014 -0400

    Data Processing post-bootstrap 3 UI fixes

    Some of the data processing forms were showing extra fields
    that should have been hidden. That was fixed by using
    form-group rather than control-group. Also, the cancel button
    was missing its outline on some of the forms because it was
    missing the btn-default class. Other buttons used to choose
    libraries and add configs were also missing btn-default.
    * Details pages had a large gap, fixed row-fluid --> col-sm-12
    * row-fluid --> row in other places per migration guide
    * icon-plus/minus --> glyphicon-plus/minus
    * select inputs have now have form-control class
    * unnecessary margins deleted for "Remove" buttons
    * list-style added for node processes <ul>

    Co-Authored-By: Nikita Konovalov <email address hidden>
    Change-Id: I5f988516290c95e6dba663aa58abeb07563c5bb4
    Closes-Bug: #1350372
    Closes-Bug: #1352590
    Closes-Bug: #1352812

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → juno-3
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.