OpenStack Dashboard (Horizon)

[UI][Sahara] In case of job execution validation failure UI doesn't display error right

Bug #1350110 reported by Andrew Lazarev on 2014-07-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Andrew Lazarev	OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

Steps to repro:

1. create cluster without oozie
2. run job on it using UI

Expected result: UI will display that oozie is missing
Observed result: Failure error with 'None' description. See screenshot.

Revision history for this message

Andrew Lazarev (alazarev) wrote on 2014-07-30:

Screen Shot 2014-07-29 at 5.13.22 PM.png Edit (34.5 KiB, image/png)

Andrew Lazarev (alazarev) on 2014-07-31

summary:

- [UI] In case of job execution validation failure UI doesn't display
- error right
+ [UI][Sahara] In case of job execution validation failure UI doesn't
+ display error right

Andrew Lazarev (alazarev) on 2014-07-31

Changed in horizon:
assignee:	nobody → Andrew Lazarev (alazarev)
Changed in sahara:
assignee:	nobody → Andrew Lazarev (alazarev)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-31: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110837

Changed in horizon:
status:	New → In Progress

Sergey Lukjanov (slukjanov) on 2014-07-31

Changed in sahara:
milestone:	none → juno-3
status:	New → Confirmed
importance:	Undecided → Medium
status:	Confirmed → In Progress

David Lyle (david-lyle) on 2014-08-04

Changed in horizon:
milestone:	none → juno-3
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-05: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/110837
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=26351aa5908ecd8f97fe8083bf1a64ed25729a2f
Submitter: Jenkins
Branch: master

commit 26351aa5908ecd8f97fe8083bf1a64ed25729a2f
Author: Andrew Lazarev <email address hidden>
Date: Wed Jul 30 19:38:08 2014 -0700

Fixed error message for recoverable exceptions

    Issue was introduced by https://review.openstack.org/#/c/76354/
    In case of recovarable exceptions message is None and exc_value
    need to be used. But after encoding.force_unicode(message) message
    becomes u'None' and all checks on "if message" pass. This result
    in popup screen with 'None' text instead of problem description.

Change-Id: I7bc2dd02f97ba2bb10a7fadd2c1b86b011eb5967
Closes-Bug: #1350110