Listing volumes has poor performance (due to glance metadata)

[Mathieu Gagné]

Listing volumes with a non-admin user has poor performance.

This is caused by the query built to retrieve glance metadata associated to a volume which is sub-optimal: all rows of volume_glance_metadata table are returned.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110357

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110357
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8f8a8a6ffe14cf7bb461dc26d178bf8acc8ddf12
Submitter: Jenkins
Branch: master

commit 8f8a8a6ffe14cf7bb461dc26d178bf8acc8ddf12
Author: Mathieu Gagné <email address hidden>
Date: Tue Jul 29 11:57:15 2014 -0400

    Fix glance metadata SQL query performance

    The query built to retrieve glance metadata associated to a volume
    was sub-optimal: all rows of volume_glance_metadata were returned.

    Fix it by properly joining the 2 tables with volume_id field.

    Closes-bug: #1349936
    Change-Id: Ic09414de769e71f8b8f99113838af48d8520e187

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106238
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ce35e7a2558d5b62617616c3ec930c79213186d6
Submitter: Jenkins
Branch: stable/icehouse

commit ce35e7a2558d5b62617616c3ec930c79213186d6
Author: Mathieu Gagné <email address hidden>
Date: Thu Jul 3 15:30:05 2014 -0400

    volume_image_metadata missing from volume list

    The volume_image_metadata field was missing from the volume list
    because we tried to filter VolumeGlanceMetadata against a non-existent
    project_id field. Filtering should be done on the Volume associated
    to the VolumeGlanceMetadata instead.

    Move project_id filtering out of model_query as it assumes
    the project_id field is in the queried model itself.
    Build the filter ourselves against Volume.

    Fix glance metadata SQL query performance

    The query built to retrieve glance metadata associated to a volume
    was sub-optimal: all rows of volume_glance_metadata were returned.

    Fix it by properly joining the 2 tables with volume_id field.

    Closes-bug: #1337526
    Closes-bug: #1349936
    Change-Id: I6053708296f2b5e24513dc87ed63da0f67c220ae
    (cherry picked from commit 06dd7f28d1d3ec8619df0d25ddfe977d538897b3)
    (cherry picked from commit 8f8a8a6ffe14cf7bb461dc26d178bf8acc8ddf12)