DVR vmarp table update causes exception in L3 service plugin

[Sukhdev Kapur]

DVR implementation assumes that dvr_vmarp_table_update() method is supported by L3 Router service plugin. With the vendor's version of L3 Router Service plugins that assumption may not be true and hence the invocation of this method throws an exception.

I noticed this during the testing of Arista's L3 router plugin. I notice that other similar plugins from other vendors are on their way, and will hit this issue as well.

[Armando Migliaccio (armando-migliaccio)]

Hi Sukhdev, is this something that's been exercised by 3rd CI party CI's? Do you have a trace of the failure?

I can look into this if you like.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110190

[Sukhdev Kapur (sukhdev-8)]

Hi Armando, this will be hit by the third party CIs as well. However, I hit while I was testing my L3 Router plugin for Arista HW.
I believe your fix is better than the one I came up as a work around - as this was blocking my progress.
I will test your fix in the morning and report back.
Thanks for such a quick response.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110190
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3eee50510fed29a7a8d97d4193a1c3c0a209a712
Submitter: Jenkins
Branch: master

commit 3eee50510fed29a7a8d97d4193a1c3c0a209a712
Author: armando-migliaccio <email address hidden>
Date: Mon Jul 28 20:09:04 2014 -0700

    Make dvr_vmarp_table_update call conditional to dvr extension

    Without making this call conditional, every l3plugin that
    integrates with the ML2 plugin will need to implement this
    method and this must not be necessary.

    Closes-bug: #1349638

    Change-Id: Ie9ba3bad4152810f5bfa530be54be70139cebc0c