[library] nova-network OCF script does not count configuration lines in /etc/nova/nova.conf

Bug #1349501 reported by Igor Zinovik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Igor Zinovik

Bug Description

nova-network OCF script (deployment/puppet/vmware/files/ocf/nova-network) does not count lines with `flat_network_bridge'
in /etc/nova/nova.conf.

It must invoke `wc' to count lines. Without getting correct value
`flat_network_bridge_nlines' OCF script does not work.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110053

Changed in fuel:
assignee: nobody → Igor Zinovik (izinovik)
status: New → In Progress
Igor Zinovik (izinovik)
summary: - [library] nova-network OCF script incorrectly count confuguration lines
- in /etc/nova/nova.conf
+ [library] nova-network OCF script does not count confuguration lines in
+ /etc/nova/nova.conf
Igor Zinovik (izinovik)
summary: - [library] nova-network OCF script does not count confuguration lines in
+ [library] nova-network OCF script does not count configuration lines in
/etc/nova/nova.conf
Changed in fuel:
milestone: none → 6.0
importance: Undecided → Low
Igor Zinovik (izinovik)
description: updated
Revision history for this message
Andrey Danin (gcon-monolake) wrote :

Without this fix we cannot manage nova-network via OCF.

Changed in fuel:
milestone: 6.0 → 5.1
importance: Low → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/110053
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=432ad46a452958e147e2fc06430c99a1655d8936
Submitter: Jenkins
Branch: master

commit 432ad46a452958e147e2fc06430c99a1655d8936
Author: Igor Zinovik <email address hidden>
Date: Mon Jul 28 19:19:42 2014 +0400

    properly count configuration settings in $OCF_RESKEY_CONFIG

    - instead of invoking external utilities like `wc', use builtin grep
      `-c' option (specifed by POSIX), which hides regular output and emits
      number of matching lines

    Closes-bug: #1349501
    Change-Id: I6afaeb0a4945cd7e221a9cf8f47dfa2328015f10

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.