keystoneclient 0.10.0 breaks django-openstack-auth unit tests completely

Bug #1349485 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
django-openstack-auth
Fix Released
Critical
Akihiro Motoki

Bug Description

In keystoneclient 0.10.0, construct parameters in v2.0 UserManager/TenantManager was changed.
http://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=658b6900493c9b169dc0dc971e8a9a0f087a0df5
http://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=0e8673769929026b9a3facc078c876be82cdf7cb

django-openstack-auth test data uses UserManager/TenantManager directly, so the unit tests no longer work.
To fix it, we need to add dummy parameters (None) to UserManager/TenantManager.

Note that this fix is not compatible with keystoneclient 0.9.0, but it cannot be avoided
because keystoneclient 0.10.0 change is not backward-compat.
The unit tests are run using the latest version of keystoneclient, so I think it can be accepted temporarily.

Once global requirements are updated to use keystoneclient >= 0.10.0 and django-openstack-auth requirements.txt is updated, the problem will be addressed.

global requirements update is now under review: https://review.openstack.org/#/c/108832/

Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to django_openstack_auth (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110050

Changed in django-openstack-auth:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to django_openstack_auth (master)

Reviewed: https://review.openstack.org/110050
Committed: https://git.openstack.org/cgit/openstack/django_openstack_auth/commit/?id=95dffe082adc72594587ed7dd36521f315655dbf
Submitter: Jenkins
Branch: master

commit 95dffe082adc72594587ed7dd36521f315655dbf
Author: Akihiro Motoki <email address hidden>
Date: Tue Jul 29 01:21:40 2014 +0900

    Replace UserManager/TenantManager with None in tests

    UserManager/TenantManager seems private classes in keystoneclient
    and the interface was changed in keystoneclient 0.10.0.
    django-openstack-auth tests actually don't need these managers,
    so this commit makes test data not use these classes.

    Change-Id: I9398c705acab262e89d4801da84ccea188980d99
    Closes-Bug: #1349485

Changed in django-openstack-auth:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in django-openstack-auth:
milestone: none → 1.1.7
Akihiro Motoki (amotoki)
Changed in django-openstack-auth:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.