[library] nova-network OCF script does not properly detects 'use_ipv6' setting
Bug #1349432 reported by
Igor Zinovik
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Medium
|
Igor Zinovik |
Bug Description
nova-network OCF script does not properly determines absence of 'use_ipv6' setting in /etc/nova/
This setting is commented by default.
Right now nova-network checks exit code of sed command, which is always true:
nova_network_
...
rc=$?
# Consider IPv4 when we did not found 'use_ipv6' stanza
if [ $rc -ne 0 ]; then
use_ipv6=false
fi
...
Better way is to check variable length.
Changed in fuel: | |
assignee: | nobody → Igor Zinovik (izinovik) |
status: | New → In Progress |
Changed in fuel: | |
importance: | Undecided → Medium |
milestone: | none → 5.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/109988 /git.openstack. org/cgit/ stackforge/ fuel-library/ commit/ ?id=851b29ac643 4c1671078ef293b b25a04dc492f49
Committed: https:/
Submitter: Jenkins
Branch: master
commit 851b29ac6434c16 71078ef293bb25a 04dc492f49
Author: Igor Zinovik <email address hidden>
Date: Mon Jul 28 17:56:11 2014 +0400
Detect absence of 'use_ipv6' stanza in /etc/nova/nova.conf
- 'use_ipv6' configuration stanza is commented by default in etc/nova/ nova.conf. We need to check return code of grep invocation
/
to detect this. If stanza is commented we consider IPv4.
Closes-bug: #1349432 9e62e5d82c12648 cc509d67a9b
Change-Id: I6311d02e4bb0ab