[library] nova-network OCF script does not interpolate $regex variable

Bug #1349430 reported by Igor Zinovik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Igor Zinovik

Bug Description

nova-network OCF script (deployment/puppet/vmware/files/ocf/nova-network) errornously uses single quotes for
variable substitution:
nova_network_cleanup()
{
...
    network_manager=$(egrep -e '^network_manager' $OCF_RESKEY_config | sed -e 's/$regexp/\1/' | tail -n 1)
...
}

Double quotes must be used for variable interpolation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110004

Changed in fuel:
assignee: nobody → Igor Zinovik (izinovik)
status: New → In Progress
Changed in fuel:
importance: Undecided → Medium
milestone: none → 5.1
Changed in fuel:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/110004
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3c19e66c2fe3dece2960bb94f7754b9e5b22c009
Submitter: Jenkins
Branch: master

commit 3c19e66c2fe3dece2960bb94f7754b9e5b22c009
Author: Igor Zinovik <email address hidden>
Date: Mon Jul 28 18:00:26 2014 +0400

    fix variables interpolation in nova_network_cleanup()

    - double quotes must be used for variable interpolation

    Change-Id: Ic0227305cd509310ef51db21a497d2b17cf3fd2b
    Closes-bug: #1349430

Changed in fuel:
status: In Progress → Fix Committed
Igor Zinovik (izinovik)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.