horizon pep8 errors

[Nikunj Aggarwal]

While running ./run_tests.sh --pep8 command, there comes many pep8 error and i think they should be resolved for better test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109948

[Akihiro Motoki (amotoki)]

I can't reproduce the bug reported with the latest code.
Could you share how to reproduce it?

ubuntu@dev02:/opt/stack/horizon (master)$ git show --summary | cat
commit 91f3fe997362ff40a197b153bad8b677af97783e
Author: Tihomir Trifonov <email address hidden>
Date: Tue Jul 29 15:02:41 2014 +0300

    Fixed wrong quota check for instance launch

    The quota check for instance launch was accidentally
    modified by a recent commit. This fixes the correct behaviour.

    Change-Id: Ibd9ef2a4843ad9e3788bac1c0e41e97abba4282f
    Closes-Bug: #1349798

ubuntu@dev02:/opt/stack/horizon (master)$ ./run_tests.sh --pep8
Checking environment.
Environment is up to date.
Running flake8 ...
ubuntu@dev02:/opt/stack/horizon (master)$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 12.04.4 LTS
Release: 12.04
Codename: precise

[Abishek Subramanian (absubram)]

Nikunj,
I believe you might be mistaken. I agree with Akihiro in that I do not hit any pep8 errors in the latest code.

I believe you are running pep8 incorrectly. Looking at your commit message, you ran ./run_tests.sh -e pep8
Akihiro can correct me but I think that is the incorrect method.

The correct command is to use tox - tox -e pep8

I do not believe this to be a bug.

[Nikunj Aggarwal (nikunj2512)]

Hi,

Akihiro & Abhishek, this my out of the pep8 test.

root@icehouse2:~/PycharmProjects/horizon# ./run_tests.sh --pep8
Checking environment.
Running flake8 ...
./openstack_dashboard/api/trove.py:111:80: E501 line too long (80 > 79 characters)
./openstack_dashboard/dashboards/admin/info/tabs.py:15:1: F401 'settings' imported but unused
./openstack_dashboard/dashboards/admin/projects/tests.py:836:5: E304 blank lines found after function decorator
./openstack_dashboard/dashboards/project/instances/tests.py:1707:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/instances/tests.py:2285:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/instances/tests.py:2295:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/data_processing/clusters/workflows/scale.py:89:80: E501 line too long (83 > 79 characters)
./openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/tabs.py:37:80: E501 line too long (80 > 79 characters)
./openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/tabs.py:60:80: E501 line too long (80 > 79 characters)
./openstack_dashboard/dashboards/project/databases/tabs.py:16:1: H306 imports not in alphabetical order (django.template, django.conf.settings)
./openstack_dashboard/dashboards/project/databases/tests.py:310:62: E202 whitespace before ')'
./openstack_dashboard/dashboards/project/databases/tests.py:337:62: E202 whitespace before ')'
./openstack_dashboard/dashboards/project/databases/tests.py:358:1: W391 blank line at end of file
./openstack_dashboard/dashboards/project/databases/workflows/create_instance.py:38:80: E501 line too long (80 > 79 characters)
./openstack_dashboard/dashboards/project/databases/workflows/create_instance.py:90:80: E501 line too long (93 > 79 characters)
./openstack_dashboard/dashboards/project/databases/workflows/create_instance.py:230:50: E202 whitespace before ']'
./openstack_dashboard/dashboards/project/networks/tests.py:414:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/networks/tests.py:452:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/networks/tests.py:521:80: E501 line too long (80 > 79 characters)
./openstack_dashboard/dashboards/project/networks/tests.py:526:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/networks/tests.py:557:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/networks/tests.py:590:9: E125 continuation line does not distinguish itself from next logical line
./openstack_dashboard/dashboards/project/access_and_security/tests.py:31:1: H306 imports not in alphabetical order (openstack_dashboard.usage.quotas, openstack_dashboard.dashboards.project.access_and_security.(api_access))
./openstack_dashboard/dashboards/project/access_and_security/tests.py:32:6: E121 continuation l...

[Akihiro Motoki (amotoki)]

First of all, all things have been fixed as bug 1347472. This bug fixed all issues more completely.

In addition, I still do not understand what happens in your environment.
At the point this bug is reported, all errors should not be detected because all checks are disabled due to the miss configuration reported in bug 1347472.
If you are interested in what is the cause, please share your tox.ini (which contains flake8 configureation).

[Akihiro Motoki (amotoki)]

I would like to mark this bug as "Invalid" because all issues have already been fixed in bug 1347472 (which is reported before this bug) and it is not clear how to reproduce the issues reported in this bug.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikunj Aggarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/109948
Reason: Fix already committed