Hardcoded setup.cfg version is messing up deployments
Bug #1349238 reported by
John Wood
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Barbican |
Fix Released
|
Critical
|
John Wood |
Bug Description
The pbr library is used to generate version numbers for Barbican, and should typically do so by forming the version using the latest tag (such as '2014.2.b2') as a base version, and then appending git commit info if after the tag. However, if setup.cfg has a 'version' property set, this overrides the base version essentially 'hard coding' it. So a solution is needed that can inject a timestamp into the version while letting PBR control the overall version stamp.
Changed in barbican: | |
status: | New → Confirmed |
importance: | Undecided → Critical |
assignee: | nobody → John Wood (john-wood-w) |
milestone: | none → juno-3 |
Changed in barbican: | |
status: | Confirmed → In Progress |
Changed in barbican: | |
status: | Fix Committed → Fix Released |
Changed in barbican: | |
milestone: | juno-3 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/109580 /git.openstack. org/cgit/ openstack/ barbican/ commit/ ?id=f7d240801cc 2ee0b60b0280e9a 7ef7723571490f
Committed: https:/
Submitter: Jenkins
Branch: master
commit f7d240801cc2ee0 b60b0280e9a7ef7 723571490f
Author: jfwood <email address hidden>
Date: Fri Jul 25 08:43:58 2014 -0500
Replace hard-coded setup version setting
The pbr library is used to generate version numbers for Barbican, and
should typically do so by forming the version using the latest tag
(such as '2014.2.b2') as a base version, and then appending git commit
info if after the tag. However, if setup.cfg has a 'version' property
set, this overrides the base version essentially 'hard coding' it. This
CR removes that override and instead lets the versionbuild.py script,
used during deployment processing, generate this version override based
on the current PBR generated version with a timestamp injected into it.
Closes-Bug: #1349238 c1e2ae182efa32a 0d1449de15c
Change-Id: I32cf9b32265569