Remove remaining users of wl_range

Bug #1348795 reported by SirVer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

I gave up on the remaining wl_const_range() for now. They are all used in the same manner and should still be removed. Basically there is a loop over a container which appends something to a string, but only for all elements but the last. E.g. for {"a", "b", "c"} it would do:

s = s + "a";
s = s + ", ";
s = s + "b";
s = s + ", ";
s = s + "c";

The better approach here is to use boost::algorithm::join() for this use case. It is more efficient and it will make that code easier to read. I think this should be done in a separate branch though and I am all for merging this one ASAP.

Related branches

SirVer (sirver)
Changed in widelands:
importance: Undecided → Low
milestone: none → build19-rc1
Revision history for this message
GunChleoc (gunchleoc) wrote :
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.