Remove remaining users of wl_range
Bug #1348795 reported by
SirVer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
I gave up on the remaining wl_const_range() for now. They are all used in the same manner and should still be removed. Basically there is a loop over a container which appends something to a string, but only for all elements but the last. E.g. for {"a", "b", "c"} it would do:
s = s + "a";
s = s + ", ";
s = s + "b";
s = s + ", ";
s = s + "c";
The better approach here is to use boost::
Related branches
lp:~widelands-dev/widelands/bug-1348795
- SirVer: Needs Fixing
- GunChleoc: Needs Resubmitting
- Tino: Approve
-
Diff: 3412 lines (+890/-658)126 files modifiedsrc/base/i18n.cc (+31/-0)
src/base/i18n.h (+7/-0)
src/logic/building.cc (+4/-21)
src/logic/building.h (+16/-1)
src/logic/constructionsite.cc (+5/-13)
src/logic/constructionsite.h (+4/-4)
src/logic/dismantlesite.cc (+5/-6)
src/logic/dismantlesite.h (+2/-2)
src/logic/militarysite.cc (+31/-24)
src/logic/militarysite.h (+2/-3)
src/logic/production_program.cc (+201/-210)
src/logic/production_program.h (+10/-3)
src/logic/productionsite.cc (+56/-57)
src/logic/productionsite.h (+18/-9)
src/logic/trainingsite.cc (+0/-9)
src/logic/trainingsite.h (+0/-2)
src/logic/worker.cc (+18/-6)
src/map_io/widelands_map_bob_data_packet.cc (+1/-2)
src/map_io/widelands_map_buildingdata_data_packet.cc (+4/-45)
src/wui/encyclopedia_window.cc (+2/-5)
tribes/atlanteans/armorsmithy/conf (+6/-3)
tribes/atlanteans/bakery/conf (+2/-1)
tribes/atlanteans/blackroot_farm/conf (+6/-3)
tribes/atlanteans/burners_house/conf (+2/-1)
tribes/atlanteans/coalmine/conf (+2/-1)
tribes/atlanteans/crystalmine/conf (+8/-4)
tribes/atlanteans/farm/conf (+6/-3)
tribes/atlanteans/fish_breeders_house/conf (+2/-1)
tribes/atlanteans/fishers_house/conf (+2/-1)
tribes/atlanteans/foresters_house/conf (+2/-1)
tribes/atlanteans/gold-spinning-mill/conf (+2/-1)
tribes/atlanteans/goldmine/conf (+2/-1)
tribes/atlanteans/horsefarm/conf (+2/-1)
tribes/atlanteans/hunters_house/conf (+2/-1)
tribes/atlanteans/ironmine/conf (+2/-1)
tribes/atlanteans/labyrinth/conf (+12/-6)
tribes/atlanteans/mill/conf (+6/-3)
tribes/atlanteans/quarry/conf (+2/-1)
tribes/atlanteans/sawmill/conf (+2/-1)
tribes/atlanteans/scouts_house/conf (+2/-1)
tribes/atlanteans/shipyard/conf (+4/-2)
tribes/atlanteans/smelting_works/conf (+6/-3)
tribes/atlanteans/smokery/conf (+6/-3)
tribes/atlanteans/spiderfarm/conf (+2/-1)
tribes/atlanteans/toolsmithy/conf (+26/-13)
tribes/atlanteans/weaponsmithy/conf (+12/-6)
tribes/atlanteans/weaving-mill/conf (+8/-4)
tribes/atlanteans/well/conf (+2/-1)
tribes/atlanteans/woodcutters_house/conf (+2/-1)
tribes/barbarians/axfactory/conf (+8/-4)
tribes/barbarians/bakery/conf (+2/-1)
tribes/barbarians/battlearena/conf (+6/-3)
tribes/barbarians/big_inn/conf (+8/-4)
tribes/barbarians/brewery/conf (+2/-1)
tribes/barbarians/burners_house/conf (+2/-1)
tribes/barbarians/cattlefarm/conf (+2/-1)
tribes/barbarians/coalmine/conf (+2/-1)
tribes/barbarians/deep_coalmine/conf (+2/-1)
tribes/barbarians/deep_goldmine/conf (+2/-1)
tribes/barbarians/deep_oremine/conf (+3/-1)
tribes/barbarians/deeper_coalmine/conf (+2/-1)
tribes/barbarians/deeper_goldmine/conf (+2/-1)
tribes/barbarians/deeper_oremine/conf (+2/-1)
tribes/barbarians/farm/conf (+6/-3)
tribes/barbarians/fishers_hut/conf (+2/-1)
tribes/barbarians/gamekeepers_hut/conf (+2/-1)
tribes/barbarians/goldmine/conf (+2/-1)
tribes/barbarians/granitemine/conf (+2/-1)
tribes/barbarians/hardener/conf (+2/-1)
tribes/barbarians/helmsmithy/conf (+8/-4)
tribes/barbarians/hunters_hut/conf (+2/-1)
tribes/barbarians/inn/conf (+6/-3)
tribes/barbarians/lime_kiln/conf (+2/-1)
tribes/barbarians/lumberjacks_hut/conf (+2/-1)
tribes/barbarians/metalworks/conf (+22/-11)
tribes/barbarians/micro-brewery/conf (+2/-1)
tribes/barbarians/oremine/conf (+2/-1)
tribes/barbarians/quarry/conf (+2/-1)
tribes/barbarians/rangers_hut/conf (+2/-1)
tribes/barbarians/reed_yard/conf (+6/-3)
tribes/barbarians/scouts_hut/conf (+2/-1)
tribes/barbarians/shipyard/conf (+4/-2)
tribes/barbarians/smelting_works/conf (+6/-3)
tribes/barbarians/tavern/conf (+2/-1)
tribes/barbarians/trainingcamp/conf (+18/-9)
tribes/barbarians/warmill/conf (+14/-7)
tribes/barbarians/weaving-mill/conf (+2/-1)
tribes/barbarians/well/conf (+2/-1)
tribes/empire/arena/conf (+4/-2)
tribes/empire/armorsmithy/conf (+10/-5)
tribes/empire/bakery/conf (+2/-1)
tribes/empire/brewery/conf (+2/-1)
tribes/empire/burners_house/conf (+2/-1)
tribes/empire/coalmine/conf (+2/-1)
tribes/empire/colosseum/conf (+6/-3)
tribes/empire/deep_coalmine/conf (+2/-1)
tribes/empire/deep_goldmine/conf (+2/-1)
tribes/empire/deep_marblemine/conf (+2/-1)
tribes/empire/deep_oremine/conf (+2/-1)
tribes/empire/donkeyfarm/conf (+2/-1)
tribes/empire/farm/conf (+6/-3)
tribes/empire/fishers_house/conf (+2/-1)
tribes/empire/foresters_house/conf (+2/-1)
tribes/empire/goldmine/conf (+2/-1)
tribes/empire/hunters_house/conf (+2/-1)
tribes/empire/inn/conf (+6/-3)
tribes/empire/lumberjacks_house/conf (+2/-1)
tribes/empire/marblemine/conf (+6/-3)
tribes/empire/mill/conf (+2/-1)
tribes/empire/oremine/conf (+2/-1)
tribes/empire/piggery/conf (+2/-1)
tribes/empire/quarry/conf (+6/-3)
tribes/empire/sawmill/conf (+2/-1)
tribes/empire/scouts_house/conf (+2/-1)
tribes/empire/sheepfarm/conf (+2/-1)
tribes/empire/shipyard/conf (+4/-2)
tribes/empire/smelting_works/conf (+6/-3)
tribes/empire/stonemasons_house/conf (+2/-1)
tribes/empire/tavern/conf (+2/-1)
tribes/empire/toolsmithy/conf (+26/-13)
tribes/empire/trainingcamp/conf (+18/-9)
tribes/empire/vineyard/conf (+6/-3)
tribes/empire/weaponsmithy/conf (+12/-6)
tribes/empire/weaving-mill/conf (+2/-1)
tribes/empire/well/conf (+2/-1)
tribes/empire/winery/conf (+2/-1)
Changed in widelands: | |
importance: | Undecided → Low |
milestone: | none → build19-rc1 |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Code example: http:// bazaar. launchpad. net/~widelands- dev/widelands/ bug-1203629/ revision/ 7156