cinder-manage loads more modules than necessary

Bug #1348787 reported by Eric Harney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Eric Harney

Bug Description

cinder-manage loads up more stuff than it needs to, should probably look at reducing this since it's an admin command.

For one, it loads up the paramiko library since it's used in utils.py. This seems rather unnecessary.

(Noticed because the python crypto module loaded by paramiko was throwing warnings to my terminal about linking against a newer libgmp.)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110427

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/110428

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/110427
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=75ef446fef63320e9c1ed4a04e59ffbbb62b5cef
Submitter: Jenkins
Branch: master

commit 75ef446fef63320e9c1ed4a04e59ffbbb62b5cef
Author: Eric Harney <email address hidden>
Date: Fri Jul 25 15:59:40 2014 -0400

    Move SSHPool into ssh_utils.py

    utils.py is loaded by almost everything, but SSH
    code and imports (paramiko) are only needed by certain
    drivers.

    Split this into a separate file to reduce overhead (and
    things that can break) for commands like cinder-manage.

    Partial-Bug: #1348787

    Change-Id: I46896f2bd1fd0de2aedde8e87e255398e5bc3171

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/110428
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=aad4e2437736270af7164df4fc34174bf3fb49f9
Submitter: Jenkins
Branch: master

commit aad4e2437736270af7164df4fc34174bf3fb49f9
Author: Eric Harney <email address hidden>
Date: Fri Jul 25 16:52:56 2014 -0400

    Move generate_password into volume utils

    This is only used in places where volume/utils is
    relevant, and moving it there reduces the amount of
    code that has to load the python Crypto library.

    Closes-Bug: #1348787

    Change-Id: Id74fdd2d6f12f0196055deb1b0dd610677caff0f

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/112265
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d02f79b2043869d98c7ccdcc650206a3b2ed13e6
Submitter: Jenkins
Branch: master

commit d02f79b2043869d98c7ccdcc650206a3b2ed13e6
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed Aug 6 13:58:43 2014 +0300

    RPC client lazy initialization

    All *Command classes are instantiating for each cinder-manage command
    execution. RPC client should be initialized for VolumeCommands usage.
    Some custom RPC clients (oslo.messaging backends) could init RPC
    connection after client initialization so it is no need to create RPC
    client for every cinder-manage command invoke.

    Related-Bug: #1348787
    Change-Id: I7b3388dded6eeec972d9949538e1608c3a538734

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.