main error logger uses "cliff.app" as name instead of the command line app's name

Bug #1348648 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cliff
Fix Released
Medium
Doug Hellmann
python-openstackclient
Invalid
Undecided
Unassigned

Bug Description

Unhandled errors reported by the main program come out from "cliff.app" instead of, for example, "openstack".

This is an error from devstack:

========================================
2014-07-14 05:53:39.430 | + create_keystone_accounts
2014-07-14 05:53:39.431 | ++ get_or_create_project admin
2014-07-14 05:53:39.433 | +++ openstack project show admin -f value -c id
2014-07-14 05:53:40.147 | +++ openstack project create admin -f value -c id
2014-07-14 05:53:40.771 | ERROR: cliff.app Service Unavailable (HTTP 503)
....

2014-07-14 05:53:41.519 | +++ openstack user create admin --password
admin --project --email <email address hidden> -f value -c id
2014-07-14 05:53:42.080 | usage: openstack user create [-h] [-f
{shell,table,value}] [-c COLUMN]
2014-07-14 05:53:42.080 | [--max-width <integer>]
[--prefix PREFIX]
2014-07-14 05:53:42.080 | [--password
<user-password>] [--password-prompt]
2014-07-14 05:53:42.080 | [--email <user-email>]
[--project <project>]
2014-07-14 05:53:42.080 | [--enable | --disable]
2014-07-14 05:53:42.080 | <user-name>
2014-07-14 05:53:42.081 | openstack user create: error: argument
--project: expected one argument
2014-07-14 05:53:42.109 | ++ USER_ID=
2014-07-14 05:53:42.109 | ++ echo
2014-07-14 05:53:42.109 | + ADMIN_USER=
2014-07-14 05:53:42.110 | ++ get_or_create_role admin
2014-07-14 05:53:42.111 | +++ openstack role show admin -f value -c id
2014-07-14 05:53:42.682 | +++ openstack role create admin -f value -c id
2014-07-14 05:53:43.235 | ERROR: cliff.app Service Unavailable (HTTP 503)
========================================

Changed in python-cliff:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Doug Hellmann (doug-hellmann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cliff (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109578

Changed in python-cliff:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cliff (master)

Reviewed: https://review.openstack.org/109578
Committed: https://git.openstack.org/cgit/openstack/cliff/commit/?id=6bb694439eae235a9e4b88361863f6dee60852ac
Submitter: Jenkins
Branch: master

commit 6bb694439eae235a9e4b88361863f6dee60852ac
Author: Doug Hellmann <email address hidden>
Date: Fri Jul 25 09:44:10 2014 -0400

    Set the main logger name to match the application

    Change the main logger to use the application's name instead of
    'cliff.app' so that unhandled errors reported as oneliners come out as
    "ERROR: myapp some problem happened" instead of
    "ERROR: cliff.app some problem happened".

    Change-Id: I7d31cb8c1700984e6bd951ee05817b2e6a915da4
    Closes-bug: #1348648

Changed in python-cliff:
status: In Progress → Fix Committed
Changed in python-cliff:
milestone: none → juno-rc1
Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → m5
milestone: m5 → none
status: New → Invalid
Changed in python-cliff:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.