Slow RPC manager tests after retry mechanism

Bug #1348586 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

The commit https://review.openstack.org/#/c/107710/ introduced a retry mechanism for NodeLocked exceptions, but the tests weren't updated to reset the default config values so that it doens't spend time sleeping, now tests are quite slow

LOGS:

(venv)[lucasagomes@lucasagomes ironic]$ testr slowest
Test id Runtime (s)
---------------------------------------------------------------------------------------------------- -----------
ironic.tests.conductor.test_manager.ManagerTestCase.test_vendor_passthru_node_already_locked 2.040
ironic.tests.conductor.test_manager.ManagerTestCase.test_destroy_node_reserved 2.038
ironic.tests.conductor.test_manager.ManagerTestCase.test_change_node_power_state_node_already_locked 2.037
ironic.tests.conductor.test_manager.ManagerTestCase.test_update_node_already_locked 2.031
ironic.tests.conductor.test_manager.ManagerTestCase.test_update_port_node_locked 2.024
ironic.tests.conductor.test_task_manager.TaskManagerTestCase.test_excl_lock_reserve_exception 2.011
ironic.tests.drivers.test_deploy_utils.RealFilePartitioningTestCase.test_different_sizes 1.631
ironic.tests.conductor.test_task_manager.TaskManagerTestCase.test_excl_lock_exception_then_lock 1.010
ironic.tests.test_glance_service.TestGlanceImageService.test_download_with_retries 1.009
ironic.tests.drivers.test_deploy_utils.RealFilePartitioningTestCase.test_whole_disk 0.207
(venv)[lucasagomes@lucasagomes ironic]$

Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
milestone: none → juno-3
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109548

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/109548
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d314d3fb9cc96489d63477b65cc917792cf642d2
Submitter: Jenkins
Branch: master

commit d314d3fb9cc96489d63477b65cc917792cf642d2
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Jul 25 12:10:32 2014 +0100

    Tune down node_locked_retry_{attempts,interval} config for tests

    Tune down the node_locked_retry_interval and
    node_locked_retry_attempts config options for tests. The commit
    428c24767575419d5b472b52f2b622588a3a7253 introduced a new retry mechanism
    for the NodeLocked exception but the config options weren't resetted for
    the tests so the tests verifying that exception were wasting time sleeping.

    Closes-Bug: #1348586
    Change-Id: Ia516ede357b00ebb19d10f2f603a3e766478c1b3

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.