share and snapshot create should return a detailed reponse

Bug #1348326 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Alex Meade

Bug Description

Performing a POST on /shares and /snapshots returns the sparse object instead of a detailed object. This is inconsistent with other openstack projects (including cinder) and should change.

As an example, a POST on /shares currently returns:
'share': {
    'name': 'Share Test Name',
    'id': '1',
    'links': [
    {
         'href': 'http://localhost/v1/fake/shares/1',
         'rel': 'self'
    },
    {
     'href': 'http://localhost/fake/shares/1',
     'rel': 'bookmark'
    }
    ],
}

but should return:
'share': {
    'name': 'Share Test Name',
    'id': '1',
    'availability_zone': 'fakeaz',
    'description': 'displaydesc',
    'export_location': 'fake_location',
    'project_id': 'fakeproject',
    'host': 'fakehost',
    'created_at': datetime.datetime(1, 1, 1, 1, 1, 1),
    'share_proto': 'fakeproto',
    'metadata': {},
    'size': 1,
    'snapshot_id': '2',
    'share_network_id': None,
    'status': 'fakestatus',
    'volume_type': '1',
    'links': [
    {
         'href': 'http://localhost/v1/fake/shares/1',
         'rel': 'self'
    },
    {
     'href': 'http://localhost/fake/shares/1',
     'rel': 'bookmark'
    }
    ],
}

Alex Meade (alex-meade)
Changed in manila:
assignee: nobody → Alex Meade (alex-meade)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119562

Changed in manila:
milestone: none → kilo-1
Changed in manila:
milestone: kilo-1 → juno-rc1
Revision history for this message
Ben Swartzlander (bswartz) wrote :

Why retargt this to Juno-1? It feels like a new feature pretending to be a bugfix. Safer to postpone to K-1 IMO. Convince me that we can't ship Juno without this bugfix.

Changed in manila:
milestone: juno-rc1 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/119562
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0ab3d9f5534c02e287b646e51a1060a8891a7642
Submitter: Jenkins
Branch: master

commit 0ab3d9f5534c02e287b646e51a1060a8891a7642
Author: Alex Meade <email address hidden>
Date: Thu Jul 24 14:36:39 2014 -0400

    Update shares and snapshot create to show details

    This patch has POST responses for share and snapshot creates return a full
    detailed representation of the resource instead of a summary response.

    Change-Id: I96cb7ade490f39ca1f1da7faecd2b6a8e23608fd
    Closes-bug: 1348326

Changed in manila:
status: In Progress → Fix Committed
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.