Wrong git version split under OSX

[David Lefever @ Taktik]

Hello,

there is a bug introduced recently in git.py.
Under OSX, git version can give something like "git version 1.8.5.2 (Apple Git-48)".
In git.py, method init_git_version, you remove "git version " from the string, then split
on the dots and try to cast as int.
The cast raises an exception as it tries to cast "2 (Apple Git-48)".

Regards,
David

[Georges Racinet (gracinet)]

Man, that was fast !

Thanks for the report and the proposed branch (you got the merge request in the wrong way, I think)

[Georges Racinet (gracinet)]

The recipe does not currently support windows, but someone just showed me one that would'nt pass your way of doing either:

$ git --version
git version 1.8.4.msysgit.0

(through TortoiseGit)

[Georges Racinet (gracinet)]

And here's the one I get after compiling Git from its git source:

$ ./git --version
git version 2.0.3.2.g996b0fd

sorry for the inconvenience, I was hoping it could be simple, for once
(I'll keep the first three digits)

[David Lefever @ Taktik (dl-taktik)]

Sorry for the merge request, I'll never be used to launchpad I guess ;)

We didn't bulletproof the solution indeed, it's never as simple as it sounds.
Thanks for the prompt answer!

[Georges Racinet (gracinet)]

fix merged, and generalized for Tortoise and compiled versions (see doctest)

[Georges Racinet (gracinet)]

About launchpad, we plan to move to Github like everybody else in the community.

But I'd like to do it after Odoo support has been stabilized.
Thanks again,

[Georges Racinet (gracinet)]

People using hub (https://hub.github.com/), a wrapper around Git for GitHub may have a version string on two lines:

$ git version
git version 1.7.9
hub version 1.11.0

just added a new doctest case for it