correct get_secgroup_uuids() to match tenant_id when name ambiguity

Bug #1348064 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
huangtianhua

Bug Description

The function get_secgroup_uuids() in neutron.py will raise the exception.PhysicalResourceNameAmbiguity if there are several securityGroup have the same name. In some use-case, it's incorrect, for example, for admin, who can get the other user's securityGroup, so we should select the group with the name which belongs to himself first, if not_existent then to raise the exception.PhysicalResourceNameAmbiguity.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109222

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/109222
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=945f3fe95a5a00993dfa1a549b57279696d1606e
Submitter: Jenkins
Branch: master

commit 945f3fe95a5a00993dfa1a549b57279696d1606e
Author: huangtianhua <email address hidden>
Date: Thu Jul 24 15:52:11 2014 +0800

    Match tenant_id when name ambiguity in get_secgroup_uuids()

    Neutron allows securityGroup creation with same name
    between one/more users, and the admin roles can get/use
    the other users' securityGroup. So if there are several
    securityGroups return, we should match the one which is
    belongs to the stack owner, and then to raise
    'PhysicalResourceNameAmbiguity' exception if can't match.

    Change-Id: Icb7eae35ba40a142a4d398b7c9d58c8483b9588e
    Closes-Bug: #1348064

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.