state/watcher: FastPeriodSuite.TestWatchAfterKnown failure

[Dave Cheney]

This test has started to fail today on two systems linux/amd64 under golang-go, and linux/ppd64 under gccgo-4.9

FAIL: watcher_test.go:228: FastPeriodSuite.TestWatchAfterKnown

insert("test", "a") => revno 2
watcher_test.go:234:
    assertChange(c, s.ch, watcher.Change{"test", "a", revno})
watcher_test.go:118:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {test a 2}

[LOG] 0:10.024 INFO juju.testing reset successfully reset admin password
OOPS: 23 passed, 1 FAILED
--- FAIL: TestPackage (14.07s)
FAIL
FAIL github.com/juju/juju/state/watcher 14.176s

[Dave Cheney (dave-cheney)]

The test is timing related. If I run it on an unloaded machine it passes. If I load up my machine, the test fails.

[Ian Booth (wallyworld)]

This one also fails sometimes under load

FAIL: watcher_test.go:590: FastPeriodSuite.TestNonMutatingTxn

insert("test", "a") => revno 2
insert("test", "a") => revno 2
watcher_test.go:608:
    assertNoChange(c, chA)
watcher_test.go:125:
    c.Fatalf("watch reported %v, want nothing", got)
... Error: watch reported {test a 2}, want nothing

[LOG] 0:00.114 INFO juju.testing reset successfully reset admin password

[Ian Booth (wallyworld)]

FAIL: watcher_test.go:401: FastPeriodSuite.TestWatchUnwatchOnQueue

insert("test", 0) => revno 2
insert("test", 1) => revno 2
insert("test", 2) => revno 2
insert("test", 3) => revno 2
insert("test", 4) => revno 2
insert("test", 5) => revno 2
insert("test", 6) => revno 2
insert("test", 7) => revno 2
insert("test", 8) => revno 2
insert("test", 9) => revno 2
watcher_test.go:420:
    c.Fatalf("not enough changes: got %d, want %d", len(seen), N/2)
... Error: not enough changes: got 4, want 5

[LOG] 0:10.110 INFO juju.testing reset successfully reset admin password

[Ian Booth (wallyworld)]

FAIL: watcher_test.go:625: SlowPeriodSuite.TestWatchBeforeRemoveKnown

insert("test", "a") => revno 2
remove("test", "a") => revno -1
watcher_test.go:631:
    assertChange(c, s.ch, watcher.Change{"test", "a", revno1})
watcher_test.go:118:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {test a 2}

[LOG] 0:10.069 INFO juju.testing reset successfully reset admin password