webapps user scripts overriding StateSaver saved url
Bug #1347764 reported by
Bill Filler
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| The Webapps-core project |
Fix Released
|
Medium
|
Jean-Francois Moy | ||
| webbrowser-app |
Fix Released
|
Medium
|
Jean-Francois Moy | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| webbrowser-app (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
placeholder bug for issue that has been discussed already:
webapps and webbrowser are now using StateSaver to restore previous url if they are killed by oom killer. There is an issue with webapps that use user scripts (currently Facebook) where the user script runs after the save url is restored and overwrites it with it's own url. This will need to be updated to honor the value saved by StateSaver, if present.
Related branches
lp:~abreu-alexandre/webbrowser-app/webapp-homepage
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
- David Barth (community): Approve
-
Diff: 872 lines (+288/-103)16 files modifiedpo/webbrowser-app.pot (+14/-14)
src/app/webcontainer/Chrome.qml (+1/-1)
src/app/webcontainer/WebApp.qml (+4/-12)
src/app/webcontainer/WebViewImplOxide.qml (+34/-20)
src/app/webcontainer/WebViewImplWebkit.qml (+4/-1)
src/app/webcontainer/WebappContainerWebview.qml (+5/-2)
src/app/webcontainer/url-pattern-utils.cpp (+28/-7)
src/app/webcontainer/url-pattern-utils.h (+2/-1)
src/app/webcontainer/webapp-container.cpp (+24/-13)
src/app/webcontainer/webapp-container.h (+1/-1)
src/app/webcontainer/webapp-container.qml (+24/-9)
tests/autopilot/webapp_container/tests/__init__.py (+43/-5)
tests/autopilot/webapp_container/tests/fake_servers.py (+28/-8)
tests/autopilot/webapp_container/tests/test_app_launch.py (+1/-1)
tests/autopilot/webapp_container/tests/test_redirection_pattern.py (+59/-0)
tests/unittests/container-url-patterns/tst_ContainerUrlPatternsTests.cpp (+16/-8)
| Changed in webapps-core: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in webbrowser-app: | |
| assignee: | nobody → Arthur Mello (artmello) |
| Changed in unity-webapps-qml: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app: | |
| assignee: | Arthur Mello (artmello) → nobody |
Revision history for this message
| David Barth (dbarth) wrote | #2 |
| tags: | added: touch-2014-10-09 usability |
| Changed in webapps-core: | |
| importance: | Undecided → Medium |
| Changed in webbrowser-app: | |
| importance: | Undecided → Medium |
| no longer affects: | unity-webapps-qml |
| Changed in webbrowser-app: | |
| status: | New → Triaged |
| Changed in webapps-core: | |
| status: | New → Triaged |
| Changed in webbrowser-app: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in webbrowser-app: | |
| assignee: | Alexandre Abreu (abreu-alexandre) → Jean-Francois Moy (jfmoy) |
| Changed in webapps-core: | |
| assignee: | Alexandre Abreu (abreu-alexandre) → Jean-Francois Moy (jfmoy) |
| tags: |
added: touch-2014-10-23 removed: touch-2014-10-09 |
| tags: |
added: touch-2014-10-30 removed: touch-2014-10-23 |
| tags: |
added: touch-2014-11-06 removed: touch-2014-10-30 |
| tags: |
added: touch-2014-11-13 removed: touch-2014-11-06 |
| tags: | removed: touch-2014-11-13 |
| Changed in webapps-core: | |
| status: | Triaged → Fix Released |
| Changed in webbrowser-app: | |
| status: | Triaged → Fix Released |
| Changed in webbrowser-app (Ubuntu RTM): | |
| status: | New → Fix Released |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Note: a custom solution was originally preferred to StateSaver for restoring the previous URL. It’s being backed out of the webapps container, and StateSaver will probably replace it there, but it’s not done yet. So technically, this bug is not currently valid. I’ll leave it open though, and we’ll need to revisit it later.