OpenStack Dashboard (Horizon)

The container dashboard does not handle unicode url correctly

Bug #1347734 reported by George Peristerakis
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
George Peristerakis
OpenStack Dashboard (Horizon) 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
OpenStack Dashboard (Horizon) 2014.1.4

Bug Description

In many places in the container dashboard, the arguments passed into the reverse function are processed with urlquote.

ie reverse(url_name, args(urlquote(container_name))

This causes the container name to be quoted twice, since reverse runs urlquote also. The results are errors from the swift backend.

George Peristerakis (george-peristerakis)
Changed in horizon:
assignee: nobody → George Peristerakis (george-peristerakis)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109009

Changed in horizon:
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/109009
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=36ef6d80c9ab5fc7a3a8c4889bc4f5730573b435
Submitter: Jenkins
Branch: master

commit 36ef6d80c9ab5fc7a3a8c4889bc4f5730573b435
Author: George Peristerakis <email address hidden>
Date: Wed Jul 23 10:35:42 2014 -0400

    Remove the urlquote to arguments passed to reverse

    In the container dashboard, I removed the urlquote to all
    arguments passed to the reverse function since the reverse
    function runs the urlquote on the arguments.

    Change-Id: I4186ded9a2f52b6e56a12e8c521cb33fb3633a48
    Closes-Bug: 1347734
    Co-Authored-By: Masco Kaliyamoorthy <email address hidden>

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/142007

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/142007
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c37aafa52206d075db236a87cc35b8f2d58b2524
Submitter: Jenkins
Branch: stable/icehouse

commit c37aafa52206d075db236a87cc35b8f2d58b2524
Author: George Peristerakis <email address hidden>
Date: Wed Jul 23 10:35:42 2014 -0400

    Remove the urlquote to arguments passed to reverse

    In the container dashboard, I removed the urlquote to all
    arguments passed to the reverse function since the reverse
    function runs the urlquote on the arguments.

    Change-Id: I4186ded9a2f52b6e56a12e8c521cb33fb3633a48
    Closes-Bug: 1347734
    Co-Authored-By: Masco Kaliyamoorthy <email address hidden>
    (cherry picked from commit 36ef6d80c9ab5fc7a3a8c4889bc4f5730573b435)

tags: added: in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.