HTMLElement final class string getter

Bug #1347071 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Thai Tran

Bug Description

The class_string property does NOT return the final class string. This is evident in some of the BatchAction classes (which is a subclass). The only way to get the final class string is through the get_final_attrs method.

In order to retrieve the final class string, we would need to calculate the final attributes. This can be cumbersome if all we want is the final class string. We need a mechanism that would allow us to retrieve just the final class independently.

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/108147
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=48d725a211948fd5718db32a944baacbf130449f
Submitter: Jenkins
Branch: master

commit 48d725a211948fd5718db32a944baacbf130449f
Author: Thai Tran <email address hidden>
Date: Sat Aug 9 22:50:05 2014 -0700

    Allow access to HTML final class string

    The class_string property does NOT return the final class string.
    This is evident in some of the BatchAction classes (which is a subclass).
    The only way to get the final class string is through the get_final_attrs
    method.

    In order to retrieve the final class string, we would need to calculate
    the final attributes. This can be cumbersome if all we want is the final
    class string. This patch re-factored the code so that the final
    class string can be retrieved independently.

    Change-Id: I8f56ab407ac6426781cee4b531494d3ef2d41ea1
    Closes-Bug: #1347071

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
Thai Tran (tqtran) wrote :
Revision history for this message
Thai Tran (tqtran) wrote :

Disregard, just using this for temporary image upload.

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.