Improve logging for functions

Bug #1346968 reported by Alexey Ivanitskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Invalid
Low
Alexey Ivanitskiy

Bug Description

There are some places in code, where we raise error mesages during resolve build in functions. These messages don't propogate to user and can not be used for debugging. So we should add log messages for these purposes.

Changed in heat:
assignee: nobody → Alexey (aivanitskiy)
Revision history for this message
Steven Hardy (shardy) wrote :

Note that if you want to improve the message for the user, then raising a descriptive exception is the right thing to do, as the logs are not visible to any (non developer) users.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109333

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/109984

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Alexey Ivanitskiy (<email address hidden>) on branch: master
Review: https://review.openstack.org/109984

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Alexey Ivanitskiy (<email address hidden>) on branch: master
Review: https://review.openstack.org/109984
Reason: this patch was abandon because it has wrong Change-ID

Revision history for this message
Angus Salkeld (asalkeld) wrote :

The bug may be correct, but the solution is not to log. We need to make sure that exceptions make it to the user.

Changed in heat:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Angus Salkeld (<email address hidden>) on branch: master
Review: https://review.openstack.org/109333
Reason: Abandoning old reviews, feel free to repost to get it merged.

Changed in heat:
status: In Progress → Triaged
Zane Bitter (zaneb)
Changed in heat:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.