Upload volume to image fail on windows

Bug #1346911 reported by Claudiu Nesa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Claudiu Nesa

Bug Description

Due to fact that when uploading a volume to an image the file is opened in text mode and the different line endings style on windows glance client won't be able to upload the desired file.
Trace: http://paste.openstack.org/show/87611/
The solutions is to simply open the file in binary mode when performing this action.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109056

Changed in cinder:
assignee: nobody → Claudiu Nesa (cnesa)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/109056
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9c1214fdedd1a6ee336f25f7f84079d5918c9ff5
Submitter: Jenkins
Branch: master

commit 9c1214fdedd1a6ee336f25f7f84079d5918c9ff5
Author: ClaudiuNesa <email address hidden>
Date: Tue Jul 22 18:16:15 2014 +0300

    Fixes Cinder volume upload to image on windows

    Due to fact that when uploading a volume to an image the file is
    opened in text mode and the different line endings style on
    windows glance client won't be able to upload the desired file.
    The solutions is to simply open the file in binary mode when
    performing this action.

    Change-Id: I51b084ce38e1aaad4ded63b75b097137dedc088c
    Closes-bug: 1346911

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.