urfkilld crashed with SIGABRT in g_assertion_message()

[Tony Espy]

I've been seeing the following crash while testing the latest ofono landing for touch. This involves a lot of starting and stopping ofono.

I'm currently doing my testing on mako / image #u138.

ProblemType: Crash
DistroRelease: Ubuntu 14.10
Package: urfkill 0.6.0~20140708.110711.a0581f3-0ubuntu2
Uname: Linux 3.4.0-5-mako armv7l
ApportVersion: 2.14.4-0ubuntu2
Architecture: armhf
Date: Mon Jul 21 17:40:10 2014
ExecutablePath: /usr/lib/arm-linux-gnueabihf/urfkill/urfkilld
ExecutableTimestamp: 1405087770
InstallationDate: Installed on 2014-07-18 (3 days ago)
InstallationMedia: Ubuntu Utopic Unicorn (development branch) - armhf (20140718-020204)
ProcCmdline: /usr/lib/arm-linux-gnueabihf/urfkill/urfkilld
ProcCwd: /
ProcEnviron:
 PATH=(custom, no user)
 TERM=linux
Signal: 6
SourcePackage: urfkill
StacktraceTop:
 ?? () from /lib/arm-linux-gnueabihf/libc.so.6
 raise () from /lib/arm-linux-gnueabihf/libc.so.6
 abort () from /lib/arm-linux-gnueabihf/libc.so.6
 g_assertion_message () from /lib/arm-linux-gnueabihf/libglib-2.0.so.0
 g_assertion_message_expr () from /lib/arm-linux-gnueabihf/libglib-2.0.so.0
Title: urfkilld crashed with SIGABRT in raise()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups:

[Apport retracing service (apport)]

StacktraceTop:
 g_assertion_message (domain=domain@entry=0xb6fe1904 "URfkill", file=file@entry=0xb6fdff50 "urf-device.c", line=line@entry=509, func=func@entry=0xb6fdfd0c "urf_device_register_device", message=message@entry=0xb7ffb608 "assertion failed: (reg_id > 0)") at /build/buildd/glib2.0-2.41.1/./glib/gtestutils.c:2291
 g_assertion_message_expr (domain=0xb6fe1904 "URfkill", file=0xb6fdff50 "urf-device.c", line=509, func=0xb6fdfd0c "urf_device_register_device", expr=0xb6fdff84 "reg_id > 0") at /build/buildd/glib2.0-2.41.1/./glib/gtestutils.c:2306
 ?? ()

[Tony Espy (awe)]

From the stack trace, it looks an assertion is hit in urf_device_register_device() if the id returned from either of the calls to g_dbus_connection_register_object() is <= 0. urf_device_register_device() calls g_dbus_connection_register_object() twice, first
to register the interface_vtable passed in as an argument, and then again to register the vtable of the parent ( urf-device ).

urf_device_register_device() is called by urf_device_kernel_new() and urf_device_ofono_new().

The code looks like it was copied from the example server code at: https://developer.gnome.org/gio/2.29/GDBusConnection.html#gdbus-server. As g_dbus_connection_register_object() explicitly states that it can return an error, at minimum it would make sense to add log calls to dump out more information than a simple g_assert(reg_id > 0), however this error hints that there's probably another underlying cause ( like the ofono terminating possibly ) that might be causing this problem to occur.

[Tony Espy (awe)]

I was able to reproduce this with image #201 and a version of urfill built from the following pull request:

https://github.com/rilmodem/ofono/pull/112

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

@Tony, it seems to me that there is race condition between GetModems() DBus call returning and ModemAdded signal, and the former tries to add an interface that was already created by ModemAdded. I reconstructed the full trace in duplicated LP bug #1379232

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

Btw, I can reproduce this quite easily on Krillin just re-starting ofono:

restart ofono OFONO_RIL_DEVICE=mtk OFONO_RIL_NUM_SIM_SLOTS=2

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

This should be fixed with branch

https://github.com/cyphermox/urfkill/pull/16

[Pat McGowan (pat-mcgowan)]

marking released assuming it was forgotten, please correct if thats in error

[Mathieu Trudel-Lapierre (cyphermox)]

Reopening since the fix for this wasn't landed, it did make it to a PPA but not in RTM.

[Launchpad Janitor (janitor)]

This bug was fixed in the package urfkill - 0.6.0~20141020.151220.1dc6cf4-0ubuntu1

---------------
urfkill (0.6.0~20141020.151220.1dc6cf4-0ubuntu1) vivid; urgency=medium

  * New release snapshot:
    - UrfOfonoManager: check NULL proxy (LP: #1381818)
    - UrfOfonoManager: Fix ofono re-start case (SIGABRT with reg_id > 0)
      (LP: #1346685)
 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 11 Nov 2014 13:18:15 -0500

[Pat McGowan (pat-mcgowan)]

Approved previously on wishlist

[Olivier Moser (ecuador)]

This message appears since I uninstall evolution*, and reinstall Ubuntu-Control-Center. Ubuntu 16.04 LTS, Acer Aspire 8930G.