ceilometer.nova_client.Client.floating_ip_get_all does not return all floating ips

[WK Sze]

ceilometer.nova_client.Client.floating_ip_get_all expects to get all floating ips for all tenant. However, self.nova_client.floating_ips.list() only returns the floating ips of the current tenant. It basically returns only the floating ips assigned to the tenant which ceilometer user is in, which is typically the service tenant.

--- a/ceilometer/nova_client.py
+++ b/ceilometer/nova_client.py
@@ -134,4 +134,4 @@ class Client(object):
     @logged
     def floating_ip_get_all(self):
         """Returns all floating ips."""
- return self.nova_client.floating_ips.list()
+ return self.nova_client.floating_ips_bulk.list()

[Liusheng (liusheng)]

this report is duplicate with https://bugs.launchpad.net/nova/+bug/1262124, while the fix changes of that bug have been reverted, more details see:

https://blueprints.launchpad.net/nova/+spec/get-floatingip-by-all-tenants
http://lists.openstack.org/pipermail/openstack-dev/2014-June/037304.html
http://lists.openstack.org/pipermail/openstack-dev/2014-June/037536.html

[gordon chung (chungg)]

liusheng, you're right. i remember now. has it been fixed/patched in Nova and can we reapply your patch?

[WK Sze (swk-private+launchpad)]

Sorry that I failed to spot the existing report.

I am wondering if a similar bug for _with_image has been reported. _with_image calls nova_client.images.get, but the result is filtered by the context project id.

[Liusheng (liusheng)]

gordon chung, the main part of the fixes of the bug(Nova side) has been merged, but it has a mistake for nova-network scenario that lead to bug#1328694.
I posted a patch to fix the bug https://review.openstack.org/#/c/99251/, but Nova cores opposed to use *polling* way to meter floatingip, a thread has been posted in ML about this: http://lists.openstack.org/pipermail/openstack-dev/2014-June/037304.html, Finally, the patches are decided to revert and suggest to use other ways (like notification) to meter floatingip. the reverting changes:https://review.openstack.org/#/c/99938/ https://review.openstack.org/99212

[gordon chung (chungg)]

we stop using nova for floating_ips

https://review.openstack.org/#/c/269369/